Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 237273 - [About] About dialog does not change about.mappings for dynamic product
Summary: [About] About dialog does not change about.mappings for dynamic product
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M1   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 256926
  Show dependency tree
 
Reported: 2008-06-16 09:20 EDT by Hiroyuki Okamoto CLA
Modified: 2008-12-11 10:54 EST (History)
2 users (show)

See Also:

Attachments
Proposed fix (4.44 KB, patch)
2008-06-16 09:24 EDT, Hiroyuki Okamoto CLA 		eclipse: iplog+
Details | Diff
Test case (75.72 KB, application/force-download)
2008-07-10 11:20 EDT, Kim Horne CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroyuki Okamoto CLA 2008-06-16 09:20:49 EDT 
Build ID: I20080613-2000

Steps To Reproduce:
Our rcp application has an IProductProvider to create IProduct dynamically. In our product, IProduct.getDefiningBundle() returns different result per window. 

Problem:
Once about.mapping is loaded, that mapping is always used, and never updated, even if IProdut.getDefiningBundle() returns a different bundle later.
Comment 1 Hiroyuki Okamoto CLA 2008-06-16 09:24:37 EDT 
Created attachment 105019 [details]
Proposed fix

This is a proposed fix for ProductProperties.java in org.eclipse.ui.workbench plugin.
Comment 2 Kim Horne CLA 2008-06-19 10:32:47 EDT 
I'd be interested in how you rig all of this up at your end.  It'd be useful to know for a testcase.  Given that this introduces some pretty interesting new behavior I think we need a testcase for this...
Comment 3 Hiroyuki Okamoto CLA 2008-06-25 09:21:31 EDT 
(In reply to comment #2)
> I'd be interested in how you rig all of this up at your end.  

Kim,
Our RCP app displays different contents per window, like email client shows up on window A, wordprocessor shows up on window B. To switch product per window, we created a dynamic product by declaring <provider> in <org.eclipse.core.runtime.products> in our plugin.xml. This product maintains multiple products internally, and switches product per window, so that the about box displays different contents in each window. That's our use case.
Comment 4 Kim Horne CLA 2008-06-26 14:07:48 EDT 
That's pretty clever, but it almost seems a shame that you had to go that route.  Did you ever open any bugs with us asking for multiple products?
Comment 5 Kim Horne CLA 2008-07-10 11:20:20 EDT 
Created attachment 107089 [details]
Test case

A test case (requiring four plugins!) that verifies this fix and that this fix doesn't interfere with the latest code for bug 172692
Comment 6 Kim Horne CLA 2008-07-10 11:22:55 EDT 
Fix in HEAD. Your patch didn't apply cleanly against HEAD because of bug 172692 but it wasn't too bad.
Comment 7 Kim Horne CLA 2008-09-18 13:23:58 EDT 
Verified in I20080915-1800.
Comment 8 Raji Akella CLA 2008-11-18 15:44:55 EST 
Is it possible for you to incorporate this fix in 3.4.2 stream?