Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 237257 - Translation editor <br /> and " problem
Summary: Translation editor <br /> and " problem
Status: RESOLVED FIXED
Alias: None
Product: Babel
Classification: Technology
Component: Server (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Kit Lo CLA
QA Contact:
URL: /babel/index.php
Whiteboard:
Keywords:
: 227363 (view as bug list)
Depends on:
Blocks: 242942
  Show dependency tree
 
Reported: 2008-06-16 07:05 EDT by Piotr Kontek CLA
Modified: 2008-08-02 07:23 EDT (History)
2 users (show)

See Also:


Attachments
patch (2.65 KB, patch)
2008-08-01 22:02 EDT, Kit Lo CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kontek CLA 2008-06-16 07:05:46 EDT
There's a problem with your web resource editor. 

For org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties it shows:

<form>\<br /> <li style='text' value='1.' bindent='5'><a
href='action.synchronize'>Synchronize</a> this configuration with the
product''s defining plug-in.</li>\<br /> <li style='text' value='2.'
bindent='5'>Test the product by launching a runtime instance of
it:</li>{0}</form>

instead of

<form>\
<li style="text" value="1." bindent="5"><a
href="action.synchronize">Synchronize</a> this configuration with the
product''s defining plug-in.</li>\
<li style="text" value="2." bindent="5">Test the product by launching a runtime
instance of it:</li>{0}</form>

New line character changes into <br />, " into '.
Comment 1 Kit Lo CLA 2008-08-01 22:02:21 EDT
Created attachment 108993 [details]
patch

"double quotes changed to single quotes" should be a problem during import. Strings in the database already have singles. I opened a separate bug 242942 to track that.

htmlspecialchars(nl2br($line['string_value'])) caused the <br> tags to be displayed. Changing that to nl2br(htmlspecialchars($line['string_value'])) will correct the display of the strings.

Patch released to staging server.
Comment 2 Kit Lo CLA 2008-08-02 07:19:36 EDT
fixed
Comment 3 Kit Lo CLA 2008-08-02 07:23:59 EDT
*** Bug 227363 has been marked as a duplicate of this bug. ***