Community
Participate
Working Groups
The task editor has content assist for referencing other bugs. It would be great if that content assist was also supported in new wikitext comments and descriptions. David mentioned on bug 235222 comment 11 that Textile-J is already implemented in a way to support multiple context assist processors.
we need a Mylyn public API for either an IContentAssistProcessor or a factory that can create one. Once that is available then it's trivial to integrate it with Textile-J
Owen, the bug content assist implementation is in RepositoryCompletionProcessor .
Created attachment 104784 [details] mylyn/context/zip
yeah, I was checking RepositoryCompletionProcessor, but according to the design right now, it seems we need to change MarkupSourceViewerConfiguration.getContentAssistant a bit (adding RepositoryCompletionProcessor into it, since when focused, all commands are directed to MarkupSourceViewerConfiguration), but RepositoryCompletionProcessor is invisible from outside. Any better idea to implement this feature?
(In reply to comment #1) > we need a Mylyn public API for either an IContentAssistProcessor or a factory > that can create one. Once that is available then it's trivial to integrate it > with Textile-J or we need to build a new IContentAssistProcessor that integrates MultiplexingContentAssistProcessor and RepositoryCompletionProcessor
Created attachment 104787 [details] content assist does not work ExtensibleRichTextAttributeEditor is a good place to add RepositoryCompletionProcessor, but all content assist is overshadowed by Textile-J's.
Created attachment 104805 [details] patch part 1 for some reason I couldn't combine the two patch
Created attachment 104806 [details] patch part 2/2 couldn't create a patch combining the two to clipbroad, have to seperate them *done* * modified MarkupSourceViewerConfiguration to add bug content assist *future work* * fix the order of the content assist, right now the there is no broundary between WikiText content assist and Mylyn one * make RepositoryCompletionProcessor visible to the WikiText, at the same time some modifications might be needed
David, ur right. Steffen, how can we proceed to make RepositoryCompletionProcessor public? > we need a Mylyn public API for either an IContentAssistProcessor or a factory > that can create one. Once that is available then it's trivial to integrate it > with Textile-J
please ignore this patch! fixed in the last two > Created an attachment (id=104787) > content assist does not work > > ExtensibleRichTextAttributeEditor is a good place to add > RepositoryCompletionProcessor, but all content assist is overshadowed by > Textile-J's.
Created attachment 104809 [details] patch for getting a IContentAssistProcessor Good work Ownen. How about this patch for getting an IContentAssistProcessor? The added method could easily be accessed from the TaskMarkupSourceViewerConfiguration
Created attachment 104810 [details] mylyn/context/zip
Created attachment 104813 [details] re-do the patch: forgot static I've adapted Owen's patch and applied it to Textile-J, SVN revision 718. With this patch, we get content assist from all sides.
Created attachment 104814 [details] mylyn/context/zip
Created attachment 104819 [details] minor fixed for ExtensibleRichTextAttributeEditor fixed the font size
Owen, I am not sure how your last patch relates to this bug (it looks like a patch from David that has already been merged)? David, before we add the factory method to TasksUi which looks good to me can you use RepositoryCompletionProcessor directly in Textile-J?
Created attachment 104855 [details] screenshot showing content assist in action (In reply to comment #16) > Owen, I am not sure how your last patch relates to this bug (it looks like a > patch from David that has already been merged)? Looks to me like there's some code from my patch plus some other stuff -- owen perhaps you could re-cut the patch after having updated to the latest sources from CVS? > > David, before we add the factory method to TasksUi which looks good to me can > you use RepositoryCompletionProcessor directly in Textile-J? Completed in SVN revision 719
(In reply to comment #16) > Owen, I am not sure how your last patch relates to this bug (it looks like a > patch from David that has already been merged)? > sorry for the confusion. I should have created another bug. Please refer to bug 237131
anything to add? probably we can close this bug?
bug close?
