Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 236961 - [wikitext] hyperlinking does not work
Summary: [wikitext] hyperlinking does not work
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: David Green CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-12 16:16 EDT by Steffen Pingel CLA
Modified: 2008-06-16 21:01 EDT (History)
1 user (show)

See Also:


Attachments
mylyn/context/zip (26.04 KB, application/octet-stream)
2008-06-16 21:01 EDT, David Green CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2008-06-12 16:16:33 EDT
If I hover over a hyperlink in a wikitext comment it shows a tooltip but nothing happens when I click it, e.g.:

 http://eclipse.org/mylyn

Mylyn also has support for hyperlinking stack traces which should be supported in wikitext comments:

at org.eclipse.mylyn.internal.tasks.core.externalization.AbstractExternalizationParticipant.execute(AbstractExternalizationParticipant.java:63)
at org.eclipse.mylyn.internal.tasks.core.externalization.ExternalizationManager$ExternalizationJob.run(ExternalizationManager.java:194)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Comment 1 David Green CLA 2008-06-12 18:25:31 EDT
Agreed that hyperlinking needs some work.

BTW, I think that you'll find that hyperlinks as they are in a wikitext comment work with a CTRL+click
Comment 2 Steffen Pingel CLA 2008-06-12 19:24:02 EDT
Ah, okay, didn't realize that. Mylyn's RepositoryTextViewerConfiguration overrides this method to make hyperlinking work without pressing a key:

	@Override
	public int getHyperlinkStateMask(ISourceViewer sourceViewer) {
		return SWT.NONE;
	}
Comment 3 David Green CLA 2008-06-13 00:19:08 EDT
looks like if the SourceViewerConfiguration doesn't have preferences set then it doesn't pick up the default registered platform hyperlink detectors.  I'll have it fixed asap
Comment 4 David Green CLA 2008-06-13 00:24:26 EDT
fixed in SVN revision 717
Comment 5 David Green CLA 2008-06-16 18:56:23 EDT
Owen, please assign this issue to me.
Comment 6 David Green CLA 2008-06-16 21:01:17 EDT
Fixed in SVN revision 717
Comment 7 David Green CLA 2008-06-16 21:01:24 EDT
Created attachment 105114 [details]
mylyn/context/zip