This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 236006 - [Viewers] Add tooltip support for DelegatingStyledCellLabelProvider
Summary: [Viewers] Add tooltip support for DelegatingStyledCellLabelProvider
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: 4.4 M5   Edit
Assignee: Robin Stocker CLA
QA Contact: Wojciech Sudol CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-06 05:37 EDT by Pavel Sklenak CLA
Modified: 2014-01-25 11:19 EST (History)
3 users (show)

See Also:

Attachments
Patch: added tooltip methods of CellLabelProvider (9.66 KB, patch)
2010-07-02 22:29 EDT, Davy Meers CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Sklenak CLA 2008-06-06 05:37:22 EDT 
Build ID:  I20080530-1730

Steps To Reproduce:
DelegatingStyledCellLabelProvider has support for IFontProvider and IColorProvider but not for tooltip methods defined in CellLabelProvider

I can delegate it from DelegatingStyledCellLabelProvider to IStyledLabelProvider by myself, but it should be nice to have it in standard api...
Comment 1 Boris Bokowski CLA 2009-11-26 09:54:51 EST 
Hitesh is now responsible for watching bugs in the [Viewers] component area.
Comment 2 Davy Meers CLA 2010-07-02 22:29:13 EDT 
Created attachment 173342 [details]
Patch: added tooltip methods of CellLabelProvider

I added an implementation of the tooltip methods of the CellLabelProvider.

We delegate to the provided IStyledLabelProvider if it is an instance of the CellLabelProvider, otherwise we delegate to the superclass
Comment 3 Robin Stocker CLA 2013-11-02 11:43:51 EDT 
I implemented this myself before finding this bug. Pushed my implementation as Gerrit review (so the work to include this is just pressing "Submit"):

https://git.eclipse.org/r/18004
Comment 4 Dani Megert CLA 2014-01-07 08:12:34 EST 
(In reply to Robin Stocker from comment #3)
> I implemented this myself before finding this bug. Pushed my implementation
> as Gerrit review (so the work to include this is just pressing "Submit"):
> 
> https://git.eclipse.org/r/18004

Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=39b4efc9f8668a284151ed2fc4b08987b743f73c

Thanks Robin!
Comment 5 Paul Webster CLA 2014-01-21 14:19:58 EST 
In 4.4.0.I20140120-2000

Robin, could you please verify that you can use the new implementation in the I build?

PW
Comment 6 Robin Stocker CLA 2014-01-25 11:19:54 EST 
(In reply to Paul Webster from comment #5)
> Robin, could you please verify that you can use the new implementation in
> the I build?

I tried it by importing org.eclipse.jface from platform.ui master in the workspace and removing our special case for tooltips. It works, thanks.