Community
Participate
Working Groups
RC3 I am unable to establish a CVS pserver connection to 206.191.52.48 port 80 from behind a firewall. Investigation with Ethereal/Wireshark reveals that the local proxy is being bypassed, despite its configuration. This may be because the enable proxy authentication and gated username and passwords are broken for at least a manual internet proxy configuration. They can be entered and applied, but reactivating the preferences shows that they were not persisted. Reproducible in a clean from ZIP Win32 installation of just Eclipse. Window->Preferences.General.Network Connections. Select manual proxy. Configure enabled proxy, user, password Apply, Ok Window->Preferences.General.Network Connections. config is lost. ---- org.eclipse.core.net.prefs shows #Wed Jun 04 15:04:02 BST 2008 proxyData/HTTP/hasAuth=false proxyData/HTTP/host=proxy org.eclipse.core.net.hasMigrated=true eclipse.preferences.version=1 proxiesEnabled=true proxyData/HTTP/port=80 nonProxiedHosts=127.0.0.1|localhost no sign of the user (or password).
Seems to be related to introducing the secure storage in this area.
The problem was created by the bug 226459, not by the secure storage. Note those lines in the patch for that bug: - if (!proxiesEnabled) { + if (proxiesEnabled && !systemProxiesEnabled) { in the file org.eclipse.ui.internal.net.ProxyPreferencePage method initializeValues.
Thanks Oleg for quick response. I'm looking at it now.
Created attachment 103762 [details] Proposed fix v01
+1 for 3.4 RC4
Looks fine to me too, +1.
Hmm I don't know the code. The user/password should be enabled only when "manual proxy configuration" is selected? If that's correct, should not the condition of clearing user/password be !(manual) = !(proxiesEnabled && !systemProxiesEnabled) = !proxiesEnabled || systemProxiesEnabled It seems to be the same condition as the proposed in the patch: (!proxiesEnabled || (proxiesEnabled && systemProxiesEnabled)) but just a tiny bit simpler.
(In reply to comment #7) > Hmm I don't know the code. The user/password should be enabled only when > "manual proxy configuration" is selected? > > If that's correct, should not the condition of clearing user/password be > > !(manual) > = !(proxiesEnabled && !systemProxiesEnabled) > = !proxiesEnabled || systemProxiesEnabled > > It seems to be the same condition as the proposed in the patch: > (!proxiesEnabled || (proxiesEnabled && systemProxiesEnabled)) > but just a tiny bit simpler. You're right Oleg, but afaik there is "manual" flag in the code, and the others are taken from proxyService object. Is that right Szymon?
(In reply to comment #7) > You're right Oleg, but afaik there is "manual" flag in the code, and the others > are taken from proxyService object. Is that right Szymon? Right, manual = proxiesEnabled && !systemProxiesEnabled which are taken from ProxyService object. Looking at this code now, I see it needs some refactoring. I wanted my changes related to OS support to be not too invasive...
Released to HEAD with "!proxiesEnabled || systemProxiesEnabled" condition.
*** Bug 236078 has been marked as a duplicate of this bug. ***
