Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 234489 - [ui] StructuredViewerProvisioningListener should attempt to batch refreshes
Summary: [ui] StructuredViewerProvisioningListener should attempt to batch refreshes
Status: VERIFIED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M5   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-28 16:05 EDT by Susan McCourt CLA
Modified: 2010-01-26 12:53 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2008-05-28 16:05:51 EDT
In bug #234177 comment 1 John said:
>In particular,
>StructuredViewerProvisioningListener invokes a refresh of the view for each
>repository discovery event, and since the Ganymede site has 62 references, it
>causes 62 refreshes of the tree and the UI goes berserk. 

This actually happens on repository add events, but the symptom is correct.  The viewer listener will refresh for every add.  Some of my experiments in bug #229069 involved trying to ignore refreshes when I knew there was a pending refresh.  Due to the async nature of the event handling, this approach didn't fix bug #229069 so I did not release any of those experiments.

However, a similar approach to the first patch in bug #229069 should be adopted generically by the StructuredViewerProvisioningListener.  Specifically, the implementation of asyncRefresh() could check a flag to see if a refresh was already pending, and if so, another one would not be queued up.
Comment 1 Susan McCourt CLA 2008-05-29 00:35:26 EDT
The other issue involved here is that the AvailableIUGroup currently expands added repositories and when batching, we probably shouldn't bother expanding.
Comment 2 Susan McCourt CLA 2008-06-10 15:40:42 EDT
>The other issue involved here is that the AvailableIUGroup currently expands
>added repositories and when batching, we probably shouldn't bother expanding.

That issue is now covered separately in bug #236485
Comment 3 Susan McCourt CLA 2009-11-23 12:04:27 EST
attempts to solve this are happening in the api branch, should be able to close this once we're happy with a solution.
Comment 4 Susan McCourt CLA 2009-11-24 13:04:26 EST
marking fixed (in the branch).
The events themselves remain internal, but there is a way for clients to signal to ProvisioningUI that they want to batch a repository operation and then provide detail about what happened when it's done.
Comment 5 Susan McCourt CLA 2009-12-01 12:57:00 EST
changing milestone to M5.  The p2 api branch will be merged back into HEAD early in M5
Comment 6 Susan McCourt CLA 2010-01-26 12:53:19 EST
verified on win7, I20100126-0100 (source inspection)
and by virtue of related bugs being fixed/verified