Community
Participate
Working Groups
Mylyn should provide two extension points for contributing lightweight markup viewers and editors. The extension points might look something like this: <!-- a way of declaring an editor kit --> <issueEditorKit name="Textile" id="org.example.textileKit"> <viewer class="org.example.textile.TextileViewer" <-- a class that can display lightweight markup, possibly an ISourceViewer although could be something more generic in order to support browser control, etc <editor class="org.example.textile.editor.TextileSourceViewer" <-- a class that implements ISourceViewer configuration="org.example.textile.editor.TextileSourceViewerConfiguration" <-- a SourceViewerConfiguration contextId="org.eclipse.textile.editor" <-- a context id that is activated with the IContextService when the editor is active </issueEditorKit> <!-- a way of making an editor kit the default for a specific repository --> <repositoryEditorConfiguration repositoryId="org.eclipse.mylyn.bugzilla.repository" issueEditorKitId="org.example.textileKit"/>
Created attachment 103890 [details] patch from bug 234210
David, I have taken your patch from bug 234210 and moved the extension point to the sandbox. I have only made minor modifications: - renamed repositoryKind to connectorKind - renamed TaskEditorExtension to AbstractTaskEditorExtension Can you take a quick look at the patch? If it you are okay with the changes I'll apply the patch and Owen can start working on the editor integration.
(In reply to comment #2) > David, I have taken your patch from bug 234210 and moved the extension point to > the sandbox. I have only made minor modifications: The patch looks great! > > - renamed repositoryKind to connectorKind > - renamed TaskEditorExtension to AbstractTaskEditorExtension > > Can you take a quick look at the patch? If it you are okay with the changes > I'll apply the patch and Owen can start working on the editor integration. > Sounds good. Will it be possible to have the sandbox replace the AttributeEditorFactory of a repository's editor? The AttributeEditorFactory appears to be the best integration point right now, except for setting the context id.
Steffen: anything left for me to do here?
> Will it be possible to have the sandbox replace the AttributeEditorFactory of a > repository's editor? The AttributeEditorFactory appears to be the best > integration point right now, except for setting the context id. Yes, that could be a good way for embedding a wikitext editor. AttributeEditorFactory is currently intended to be extended by connectors only but we can consider making that more extensible and provide a mechanism to contirubte alternative editors for certain attribute types. Marking resolved and reassigning to you David. We use bug assignment to recognize who has done the work. Resolving Mylyn bugs is the way to build up merit in the project :).
(In reply to comment #5) > Marking resolved and reassigning to you David. We use bug assignment to > recognize who has done the work. Resolving Mylyn bugs is the way to build up > merit in the project :). Great, thanks!