Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 233807 - Move replaceAllIgnoreCase to StringUtils
Summary: Move replaceAllIgnoreCase to StringUtils
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.0.0   Edit
Assignee: Markus Kuppe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 236033
Blocks:
  Show dependency tree
 
Reported: 2008-05-24 09:18 EDT by Markus Kuppe CLA
Modified: 2008-12-19 03:03 EST (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (1.29 KB, application/octet-stream)
2008-05-30 08:22 EDT, Markus Kuppe CLA 		no flags Details
mylyn/context/zip (1.17 KB, application/octet-stream)
2008-12-19 03:03 EST, Markus Kuppe CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2008-05-24 09:18:57 EDT 
Move org.eclipse.ecf.provider.jslp.identity.JSLPServiceTypeID.replaceAllIgnoreCase(String, String, String) to org.eclipse.ecf.core.util.StringUtils. Hasn't been done so far because of API freeze.
Comment 1 Markus Kuppe CLA 2008-05-30 08:22:30 EDT 
FIXED in HEAD. Bundle-Version: 2.1.0.qualifier for org.eclipse.ecf.core.identity has been incremented to 2.1.0 because of the API change
Comment 2 Markus Kuppe CLA 2008-05-30 08:22:33 EDT 
Created attachment 102848 [details]
mylyn/context/zip
Comment 3 Remy Suen CLA 2008-06-05 17:32:33 EDT 
Markus, I updated the method with @since 2.1 by the way.
Comment 4 Markus Kuppe CLA 2008-06-06 02:06:01 EDT 
Thanks Remy!
Comment 5 Scott Lewis CLA 2008-08-21 18:44:18 EDT 
I'm reopening this bug, because I think we should move the relevant code in jslp provider *back* to *not* using the new StringUtils.replaceAllIgnoreCase...because the platform (3.4.X and 3.4.X) controls the distribution of the org.eclipse.ecf.identity plugin, and this plugin will not have the StringUtils.replaceAllIgnoreCase until Eclipse 3.5.  Until that time (i.e. ECF 2.1, 2.X...until 3.0/Eclipse 3.5) we should not have any dependencies on new code in org.eclipse.ecf.identity.

If Markus cannot get to this before leaving on his vacation, he'll re-assign to me.
Comment 6 Markus Kuppe CLA 2008-08-22 02:50:47 EDT 
(In reply to comment #5)
> I'm reopening this bug, because I think we should move the relevant code in
> jslp provider *back* to *not* using the new
> StringUtils.replaceAllIgnoreCase...

Done in HEAD

Resetting target milestone to 3.0 and leaving it open.
Comment 7 Scott Lewis CLA 2008-08-22 14:54:42 EDT 
(In reply to comment #6)
> (In reply to comment #5)
> > I'm reopening this bug, because I think we should move the relevant code in
> > jslp provider *back* to *not* using the new
> > StringUtils.replaceAllIgnoreCase...
> 
> Done in HEAD
> 
> Resetting target milestone to 3.0 and leaving it open.
> 

In addition to this change, there seemed to be another reference to StringUtils.replaceAll... on line 48 in JSLPServiceTypeID, so I removed it and committed to HEAD.  Leaving bug open.
Comment 8 Markus Kuppe CLA 2008-12-19 03:03:23 EST 
Fixed in HEAD
Comment 9 Markus Kuppe CLA 2008-12-19 03:03:27 EST 
Created attachment 120916 [details]
mylyn/context/zip