Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 233590 - replace usage of java.util.Timer by jobs
Summary: replace usage of java.util.Timer by jobs
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 minor (vote)
Target Milestone: 3.1   Edit
Assignee: Robert Elves CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 220528 265396 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-05-22 18:04 EDT by Steffen Pingel CLA
Modified: 2009-08-10 23:50 EDT (History)
2 users (show)

See Also:

Attachments
TaskListBackkupManager patch (7.30 KB, patch)
2009-02-18 16:11 EST, Robert Elves CLA 		no flags Details | Diff
mylyn/context/zip (2.36 KB, application/octet-stream)
2009-02-18 16:11 EST, Robert Elves CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2008-05-22 18:04:23 EDT 
These classes use java.util.Timer:

- OfflineCachingStorage (deprecated)
- TaskListBackupManager
- TaskScheduleContentProvider

The non-deprecated classes should be converted to using Jobs instead of the Java Timer class.
Comment 1 Robert Elves CLA 2009-02-18 16:11:05 EST 
Created attachment 126073 [details]
TaskListBackkupManager patch

Uses job rather than time in backup manager.
Comment 2 Robert Elves CLA 2009-02-18 16:11:07 EST 
Created attachment 126074 [details]
mylyn/context/zip
Comment 3 Robert Elves CLA 2009-02-18 16:11:50 EST 
Patch applied to head
Comment 4 Robert Elves CLA 2009-02-18 16:17:51 EST 
* Look into possible concurrency issue when two threads enter TaskListBackupManager.backupNow.
Comment 5 Steffen Pingel CLA 2009-02-18 19:36:10 EST 
Invoking TasksUiInternal.logAndDisplayStatus() from a job will fail since it expects to run in the ui thread. Are you sure we should display a modal dialog when backup fails? Maybe logging to the error log is sufficient or at most display a single dialog per session.
Comment 6 Robert Elves CLA 2009-02-19 16:35:33 EST 
(In reply to comment #5)
> Invoking TasksUiInternal.logAndDisplayStatus() from a job will fail since it
> expects to run in the ui thread. Are you sure we should display a modal dialog
> when backup fails? Maybe logging to the error log is sufficient or at most
> display a single dialog per session.
Good point.  Fixed ui thread issue and an error is now reported and logged once per workbench session.
Comment 7 Robert Elves CLA 2009-02-19 17:23:12 EST 
Fixed.
Comment 8 Pascal Rapicault CLA 2009-02-20 23:29:40 EST 
*** Bug 265396 has been marked as a duplicate of this bug. ***
Comment 9 Steffen Pingel CLA 2009-08-10 23:50:18 EDT 
*** Bug 220528 has been marked as a duplicate of this bug. ***