Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 233229 - Review UpdateSiteRepo for thread safety
Summary: Review UpdateSiteRepo for thread safety
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4.1   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 239449 (view as bug list)
Depends on:
Blocks: 239449
  Show dependency tree
 
Reported: 2008-05-21 10:12 EDT by Simon Kaegi CLA
Modified: 2008-08-12 11:13 EDT (History)
3 users (show)

See Also:

Attachments
patch (1.38 KB, patch)
2008-05-21 14:47 EDT, Simon Kaegi CLA 		no flags Details | Diff
reload detect patch (2.21 KB, patch)
2008-05-26 14:10 EDT, Simon Kaegi CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2008-05-21 10:12:12 EDT 
The updatesite repos use a number of caches. We should review to ensure that we're accessing these caches safely.
Comment 1 Simon Kaegi CLA 2008-05-21 14:47:56 EDT 
Created attachment 101342 [details]
patch

This patch synchronizes the methods where we load the site and load the features.
Comment 2 Simon Kaegi CLA 2008-05-26 14:10:45 EDT 
Created attachment 102021 [details]
reload detect patch

This is a testing patch that will detect a situation where we end up calling a particular UpdateSite object's getFeature more than once. The "above" patch will prevent this from occuring. This is a test patch to help show the problem. I've seen multiple getFeature calls with larger update sites like Europa or even slow update sites like eclemma. These occur because we can end up asynchronously calling load on the Updatesite repos a number of times.
Comment 3 Simon Kaegi CLA 2008-07-16 13:20:03 EDT 
I've committed this patch to 3.5 to get some exposure.
Comment 4 Simon Kaegi CLA 2008-08-08 11:57:39 EDT 
Fixed in maintenance branch
Comment 5 Susan McCourt CLA 2008-08-12 11:13:14 EDT 
*** Bug 239449 has been marked as a duplicate of this bug. ***