Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 232504 - Reconciler activator could short-circuit earlier
Summary: Reconciler activator could short-circuit earlier
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC2   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-16 10:33 EDT by Pascal Rapicault CLA
Modified: 2008-05-22 15:41 EDT (History)
3 users (show)

See Also:
simon_kaegi: review+
pascal: review+

Attachments
patch (1.40 KB, patch)
2008-05-21 16:13 EDT, DJ Houghton CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2008-05-16 10:33:41 EDT 
From a quick scan at the code, it looks like if the isUpToDate() could be the very first thing done in the start method since it simply check the time stamps of file. This will allow us to save on the startup by not having to consult the profile and even activate a whole set of other bundles.

If moving this check before the activation of the bundles, we should at least do it before the profile loading.
Comment 1 DJ Houghton CLA 2008-05-16 11:53:08 EDT 
Good catch. When I did the original patch I was just trying to localize the changes but we can definitely perform the checks earlier.
Comment 2 Simon Kaegi CLA 2008-05-16 12:03:17 EDT 
also see bug 232445.
Comment 3 DJ Houghton CLA 2008-05-21 16:13:08 EDT 
Created attachment 101373 [details]
patch

Patch to check the timestamps early. Make sure we do it after some initialization though in case others call our public methods later on.
Comment 4 John Arthorne CLA 2008-05-22 15:41:43 EDT 
ReleaseD.