Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 232340 - WTP won't run in 'eclipse' in I20080513-2000
Summary: WTP won't run in 'eclipse' in I20080513-2000
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 232118 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-05-15 12:02 EDT by David Williams CLA
Modified: 2008-05-16 05:53 EDT (History)
9 users (show)

See Also:
simon_kaegi: review+

Attachments
patch (4.58 KB, patch)
2008-05-15 15:57 EDT, Simon Kaegi CLA 		no flags Details | Diff
patch (6.27 KB, patch)
2008-05-15 16:48 EDT, DJ Houghton CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2008-05-15 12:02:28 EDT 
Using Eclipse SDK
I20080513-2000

And unzipping WTP and pre-reqs in the 'eclipse' directory, 
WTP (nor pre-reqs) are recognized (i.e. they don't run, nothing is in log). 
Even tried -clean. 

But, found if I unzipped into 'dropins' folder, then it worked fine. 

I think this is a very recent regression.
Comment 1 John Arthorne CLA 2008-05-15 12:46:18 EDT 
Possibly related to fix for bug 231178?
Comment 2 Pascal Rapicault CLA 2008-05-15 13:03:42 EDT 
*** Bug 232118 has been marked as a duplicate of this bug. ***
Comment 3 Simon Kaegi CLA 2008-05-15 15:57:54 EDT 
Created attachment 100539 [details]
patch

This patch adds a .eclipseextension suffix to repos added via PlatformXML listener. This allows us to load a repo that otherwise would be loaded as a p2 native repo type.
Comment 4 DJ Houghton CLA 2008-05-15 16:48:43 EDT 
Created attachment 100546 [details]
patch

Here is an updated patch. Simon, please review.
Comment 5 Simon Kaegi CLA 2008-05-15 17:06:39 EDT 
Looks good. Released.
Comment 6 Karen Butzke CLA 2008-05-15 17:18:08 EDT 
a possibly related issue, setting the same build as a target platform works if
the WTP plugins are unzipped in to 'eclipse', but not if unzipped into
'dropins'.  So, it's the opposite problem than what is seen running eclipse. 
It does not matter if I first run before setting it as a target, the wtp
plugins are not found.

Is this fixed by the patch as well?
Comment 7 Pascal Rapicault CLA 2008-05-15 17:28:44 EDT 
Karen, what you are talking about is a PDE issue and I recommend you to report it ASAP against PDE UI.
Comment 8 Karen Butzke CLA 2008-05-15 17:56:58 EDT 
thanks, opened bug 232418
Comment 9 Philipe Mulet CLA 2008-05-16 03:56:55 EDT 
Do we have regression tests for it, so it does not happen again ?
Comment 10 DJ Houghton CLA 2008-05-16 05:53:55 EDT 
Not yet. I think we can write session tests to test this code but it is tricky. It is one of our next things to do.