Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 232019 - Icons for remote changes are not implemented
Summary: Icons for remote changes are not implemented
Status: CLOSED WONTFIX
Alias: None
Product: EMFCompare
Classification: Modeling
Component: UI (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P5 minor (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 232020 (view as bug list)
Depends on: 373245
Blocks:
  Show dependency tree
 
Reported: 2008-05-14 04:15 EDT by David Michonneau CLA
Modified: 2013-01-23 07:49 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Michonneau CLA 2008-05-14 04:15:21 EDT
It seems the remote provider does not pick up the model icons contributed by 
generated Edit plugins, and the image is shown as a generic diamond of EMF 
models. It works fine for local changes though. The class I refer to is 
RemoteAddModelElementItemProvider, here is the getImage() impl:

/**

* This returns RemoteAddModelElement.gif.

* <!-- begin-user-doc --> <!-- end-user-doc -->

* @generated

*/

@Override

public Object getImage(Object object) {

return overlayImage(object, 
getResourceLocator().getImage("full/obj16/RemoteAddModelElement")); 
//$NON-NLS-1$

}

Furthermore the icon referenced here is a diamond in the source code.

This problem also exists for other remote changes.
Comment 1 David Michonneau CLA 2008-05-14 04:19:46 EDT
*** Bug 232020 has been marked as a duplicate of this bug. ***
Comment 2 Laurent Goubet CLA 2012-03-05 09:02:15 EST
most icons had been implemented since this bug has been raised. Some were still missing, but the incoming metamodel restructuration will most likely deprecate them.

This bug should be verified once bug 373245 is done.
Comment 3 Laurent Goubet CLA 2013-01-22 05:51:52 EST
Some of the icons are still "diamonds" in 1.3.3 ... though most are not accessible through the UI. We will not fix the icon overlays of version 1.*

Version 2.* does not present such bugs.