Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 231329 - [decorators] decorator for native methods
Summary: [decorators] decorator for native methods
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 324314 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-05-09 11:44 EDT by Andrew Ferguson CLA
Modified: 2010-09-02 15:39 EDT (History)
3 users (show)

See Also:

Attachments
Fix (9.15 KB, patch)
2010-06-24 11:42 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Ferguson CLA 2008-05-09 11:44:12 EDT 
It would be good to have a decoration in the Outline view etc.. showing if a method is native. If there is no remaining real-estate for this, then maybe applying a filter to the entire icon so it appears in grayscale would be the way to go.
Comment 1 Markus Keller CLA 2010-05-28 08:40:58 EDT 
N can go to top-right (mutually exclusive with constructor and abstract).
Comment 2 Markus Keller CLA 2010-06-24 11:42:43 EDT 
Created attachment 172628 [details]
Fix

'native' needs to be on the top row, since the bottom row is already used for synchronized and overrides/implements method adornments on the right, and problem indicators on the left. On top, a method can already be static and final, which are both more important than native (since these affect callers as well).

I've added the 'N' to the top row, as leftmost item. That way, the 'N' can be cut off when the icon is narrow and we only have 2 slots (Package Explorer, Breadcrumb), but it is visible in the Outline, Search, and Type Hierarchy views.
Comment 3 Markus Keller CLA 2010-06-24 11:43:24 EDT 
Fixed in HEAD.
Comment 4 Deepak Azad CLA 2010-09-02 14:13:16 EDT 
*** Bug 324314 has been marked as a duplicate of this bug. ***
Comment 5 Andres Gomez Casanova CLA 2010-09-02 15:11:28 EDT 
Why was it closed? the other one is already closed. It means that the problem still exists and it has not been solved.

Bug 231329 -  [decorators] decorator for native methods
Summary: 	[decorators] decorator for native methods
Status: 	RESOLVED FIXED 

It says that:

Markus Keller      2010-06-24 11:43:24 EDT
Fixed in HEAD.

But as you can see, the problem still exists.
Comment 6 Deepak Azad CLA 2010-09-02 15:39:10 EDT 
*** Bug 324314 has been marked as a duplicate of this bug. ***