Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 231120 - "dropins" folder does not work if "eclipse" folder is renamed
Summary: "dropins" folder does not work if "eclipse" folder is renamed
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-08 09:00 EDT by CLA
Modified: 2012-07-16 08:53 EDT (History)
10 users (show)

See Also:


Attachments
Plugin to put in "dropins" folder (51.97 KB, application/octet-stream)
2008-05-08 15:50 EDT, CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description CLA 2008-05-08 09:00:26 EDT
Using 3.4 M7.  If I add a plug-in to the "dropins" folder and my eclipse installation folder is named something other than "eclipse" then the plug-in is not registered.

The "dropins" folder only works for this folder structure:

eclipse
   |------dropins


But not for this:

eclipse3.4
   |------dropins


For me this is a deal-breaker as I rename my Eclipse installation folders like "eclipse3.2", "eclipse3.3", "eclipse3.4" to keep them separate.
Comment 1 CLA 2008-05-08 09:09:44 EDT
Notes to reproduce this:

1.  Download Eclipse 3.4 M7 on windows.
2.  Unzip this to folder "eclipse".
3.  Rename the "eclipse" installation folder to "eclipse3.4"
4.  Add a known working plug-in to "dropins" folder.
5.  Launch Eclipse.

Plug-in does not register.

Workaround:

1.  Rename installation folder back to "eclipse"
2.  Launch Eclipse.
3.  Plug-in should now be registered.
4.  Close Eclipse and rename folder back to "eclipse3.4"

Comment 2 CLA 2008-05-08 10:11:32 EDT
Actually, it's worse than I thought.  Not only does the folder have to be named "eclipse" for this to work, it has to be at the top-level.  So, "c:\eclipse3.4\eclipse" for the installation folder will not work.
Comment 3 DJ Houghton CLA 2008-05-08 15:02:00 EDT
There must be something else going on because this works fine for me. I extracted 3.4 M7 and renamed the eclipse folder (D:\temp\zzz.sdk34m7\eclipse34m7) and put some plug-ins in the dropins and started and it was all good. Are you able to attach your plug-ins here for us to test with?
Comment 4 CLA 2008-05-08 15:50:44 EDT
Created attachment 99367 [details]
Plugin to put in "dropins" folder

OK,  Here's a jar plug-in.  It should appear in Eclipse as a View, "Image Gallery".  This works if the Eclipse folder is named "eclipse", but not if it is named "eclipse3.4".  This is with a fresh install.
Comment 5 CLA 2008-05-08 16:08:37 EDT
This is very strange.  If I use a new blank workspace it works OK.  If I use an installation folder called "d:\eclipse3.4" and an existing workspace called "d:\wp6_workspace" (one used from Eclipse 3.3) it doesn't work.

Comment 6 DJ Houghton CLA 2008-05-08 16:18:05 EDT
Can you print out your steps again just so we can be clear when trying to reproduce your problem? I have also been working with a clean workspace so that explains why it has been working for me. Thanks.
Comment 7 CLA 2008-05-08 16:31:33 EDT
OK, I think I've found the thing that causes it - unzipping the Delta Pack onto the Eclipse installation.

1.  Unzip Eclipse 3.4 M7 to "d:\eclipse"
2.  Unzip the Delta Pack ("eclipse-3.4M7-delta-pack") to the same location, merging the two.
3.  Rename the folder to "d:\eclipse3.4"
4.  Add the jar I attached (com.dadabeatnik.imagegallery_1.1.0) into the "dropins" folder.
5.  Launch Eclipse.  When prompted for a workspace location, select "d:\wp6_workspace"
6.  Goto Window->Show View->Other. Note there is no "Dada Beatnik/Image Gallery" view to show.
7.  Quit Eclipse.
8.  Rename the folder to "d:\eclipse".  Launch Eclipse again using the same workspace.
9.  Goto Window->Show View->Other. Note that now there *is* a "Dada Beatnik/Image Gallery" view to show.

Hope that nails it!
Comment 8 DJ Houghton CLA 2008-05-08 16:45:34 EDT
Ok, thanks. When adding the delta pack I am able to reproduce the problem. You should also see an entry similar to the following in your log file:

!SESSION 2008-05-08 16:38:45.665 -----------------------------------------------
eclipse.buildId=I20080502-0100
java.version=1.5.0_08
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US
Command-line arguments:  -os win32 -ws win32 -arch x86 -console -consoleLog

!ENTRY org.eclipse.equinox.p2.engine 4 8 2008-05-08 16:39:01.007
!MESSAGE An error occurred while collecting items to be installed
!SUBENTRY 1 org.eclipse.equinox.p2.artifact.repository 4 0 2008-05-08 16:39:01.007
!MESSAGE No repository found containing: org.eclipse.equinox.executable/org.eclipse.update.feature/3.3.100.v20080501-7G-EJsEDJEhmSVVlh7MccE
Comment 9 CLA 2008-05-08 16:49:53 EDT
Yep, I got that error log too.

So, what weirdness is going on here then?

Comment 10 Vincent Petry CLA 2008-05-09 05:03:44 EDT
I have a similar issue, on windows and linux. But the folder doesn't need to be at the top-level. Any level is okay, as long as the base folder is called "eclipse".

Second thing: I am using a bundle which provides Eclipse 3.4 M7 with the BIRT designer plugins (http://www.eclipse.org/downloads/download.php?file=/birt/downloads/drops/N-R1-2_3_0-N20080508-200805081254/birt-report-designer-all-in-one-2_3_0-N20080508.zip)
The plugins themselves in bundle are already in the "plugins" folder, not in the "dropins".

So when Eclipse first starts it will scan both the "dropins" and "plugins" folders. But at scanning time, it expects the folder name to be "eclipse". If I rename it, it will fail to find the BIRT plugins.
Comment 11 CLA 2008-05-09 05:04:57 EDT
Regarding Comment #8, this error in the log occurs regardless of the "dropins"
folder issue.  It occurs if you:

1.  Unzip 3.4 M7 to an "eclipse" folder.
2.  Unzip the Delta Pack over the "eclipse" folder.
3.  Rename the "eclipse" folder to something like "eclipse3.4"
4.  Launch Eclipse.

Comment 12 Simon Kaegi CLA 2008-05-13 22:41:51 EDT
Following the instructions in comment #7 (thanks Philip) this now works for me using I20080513-0817. I know there were some recent changes in the eclipse extensions repositories that seem related and may have corrected this problem. I'll confirm with DJ tomorrow.
Comment 13 Pascal Rapicault CLA 2008-05-13 22:49:59 EDT
Philip, could you please also verify this?
Comment 14 CLA 2008-05-14 06:26:45 EDT
I followed the same steps as in Comment #7 with build I20080513-0817 and its corresponding Delta pack and I can confirm that it all works OK now.

Good work.
Comment 15 Simon Kaegi CLA 2008-05-14 08:47:04 EDT
Thanks Philip. Marking fixed. If I had to guess I think bug 231178 is where the real fix was.
Comment 16 Simon Kaegi CLA 2008-05-14 09:52:11 EDT
.
Comment 17 Eric Cloninger CLA 2012-07-12 11:54:34 EDT
Just verified that this is still a problem on Juno. Our product is installed into "Program Files" on Windows. This prevents me from using color themes.
Comment 18 Dani Megert CLA 2012-07-16 08:53:20 EDT
(In reply to comment #17)
> Just verified that this is still a problem on Juno. Our product is installed
> into "Program Files" on Windows. This prevents me from using color themes.

This bug is marked as FIXED. If you see this (again) on newer versions, then please file a new bug report.