Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 230918 - ServiceModelManager does not properly load nor instantiate service providers
Summary: ServiceModelManager does not properly load nor instantiate service providers
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 2.1M2   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 2.1   Edit
Assignee: Chris Recoskie CLA
QA Contact: Greg Watson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-07 11:55 EDT by Chris Recoskie CLA
Modified: 2011-05-14 06:33 EDT (History)
0 users

See Also:

Attachments
proposed patch (2.26 KB, patch)
2008-05-07 11:55 EDT, Chris Recoskie CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Recoskie CLA 2008-05-07 11:55:13 EDT 
Two problems fixed in the attached patch:

- When loading service providers, the manager was incorrectly using the ID of the provider and not the service when populating the provider with the service ID
- The method which instantiates the provider was incorrectly looking for an extension with the same ID as the provider.  Since the provider has its own ID field, it cannot be assumed that the extension ID matches it.  Furthermore, you are allowed by the schema to specify more than one provider per extension.
Comment 1 Chris Recoskie CLA 2008-05-07 11:55:37 EDT 
Created attachment 99109 [details]
proposed patch
Comment 2 Greg Watson CLA 2008-05-07 17:44:43 EDT 
I'm glad you spotted it. Thanks.