Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 230807 - p2 should provide Ganymede Update Site as a default on startup
Summary: p2 should provide Ganymede Update Site as a default on startup
Status: RESOLVED DUPLICATE of bug 224278
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-06 20:03 EDT by Nick Boldt CLA
Modified: 2008-05-07 15:20 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Boldt CLA 2008-05-06 20:03:35 EDT
Apologies if this is a dupe.

Steps to repro:

(See bug 230806.) 

Instead, we ought to prepopulate p2 w/ the Ganymede update site, as we did for the Europa site last year.
Comment 1 Jeff McAffer CLA 2008-05-06 20:43:41 EDT
I agree with the idea but don't think this is a p2 issue.  it is more of an EPP thing no?
Comment 2 Pascal Rapicault CLA 2008-05-06 20:53:25 EDT

*** This bug has been marked as a duplicate of bug 224278 ***
Comment 3 Nick Boldt CLA 2008-05-06 21:26:43 EDT
(In reply to comment #1)
> I agree with the idea but don't think this is a p2 issue.  it is more of an EPP
> thing no?

No, it's a platform thing, but p2 needs to enable it.

Couldn't one of the platform features (if not p2 itself) just contribute a <discovery> URL, presumably as was done for Europa?

(See also bug 230323.)
Comment 4 John Arthorne CLA 2008-05-07 12:07:18 EDT
The org.eclipse.sdk feature provides the Ganymede discovery URL. The problem is we never actually parse feature.xml files for things that are already installed, so this needs to happen at build time.
Comment 5 Nick Boldt CLA 2008-05-07 12:46:17 EDT
(In reply to comment #4)
> The org.eclipse.sdk feature provides the Ganymede discovery URL. The problem is
> we never actually parse feature.xml files for things that are already
> installed, so this needs to happen at build time.

Sure you do... when I install EMF, I get the EMF <update> site listed -- or is the platform considered "already installed" but EMF is considered "freshly installed?"

I don't, however, get any <discovery> sites listed by default, but that's bug 230323.

What if there was a new attribute on the <discovery> node for "always on" or "enabled by default" ? The the Ganymede site could be turned on magically OOTB, but others would need to be "discovered" in the Manage Sites dialog and manually enabled... ?
Comment 6 John Arthorne CLA 2008-05-07 13:15:15 EDT
When you unzip things into dropins or plugins, we parse the feature during the install process, so we have a chance to load the discovery and update site URLs.  For feature that are "pre-installed", we never parse the feature.xml files (in fact we don't even know/care if the feature.xml files are present - we only include them for backwards compatibility). We could of course do an extra parse of all feature.xml files at some point to discover the discovery/update sites, but this adds extra startup cost.
Comment 7 Nick Boldt CLA 2008-05-07 15:20:53 EDT
(In reply to comment #6)
> We could of course do an
> extra parse of all feature.xml files at some point to discover the
> discovery/update sites, but this adds extra startup cost.

How about a "Discover" button on the UI? Or make the "Refresh" button search pre-installed features too?