Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 230354 - Search All occurences bugfix, hilight only class name when class is in search results
Summary: Search All occurences bugfix, hilight only class name when class is in search...
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: 0.95   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard: contributed
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-06 05:48 EDT by Alex Panchenko CLA
Modified: 2010-06-11 07:03 EDT (History)
1 user (show)

See Also:


Attachments
tests (11.10 KB, patch)
2008-05-06 05:48 EDT, Alex Panchenko CLA
alex.panchenko: iplog+
Details | Diff
patch (11.91 KB, patch)
2008-05-06 05:53 EDT, Alex Panchenko CLA
alex.panchenko: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Panchenko CLA 2008-05-06 05:48:08 EDT
The attached patch fixes the following issues:

1) Search All Occurrences does not work. e.g. create new module
===
class Search001
  #
  #
  #
end

f = Search001.new
===
and search for all occurrences of type "Search001"

Only class declaration is found. When searching for class references - reference is correctly located. Tests are provided.

2) When class is found and editor is opened from search results - the whole class body is hilighted in blue, making the editor unusable. JDK hilights only class name - and we should do the same.

Legal Message: I, Alex Panchenko, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer (xored software, Inc.) to make this contribution under the EPL.
Comment 1 Alex Panchenko CLA 2008-05-06 05:48:47 EDT
Created attachment 98773 [details]
tests
Comment 2 Alex Panchenko CLA 2008-05-06 05:53:57 EDT
Created attachment 98774 [details]
patch
Comment 3 Andrei Sobolev CLA 2008-05-06 08:17:43 EDT
Applied.
Comment 4 Andrey Platov CLA 2008-05-26 02:48:29 EDT
bulk change: fixed in 0.95