Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 230349 - [StatusHandling] Status label provider should not be disposed when its modality is switched
Summary: [StatusHandling] Status label provider should not be disposed when its modali...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords:
Depends on:
Blocks: 242821
  Show dependency tree
 
Reported: 2008-05-06 05:33 EDT by Szymon Brandys CLA
Modified: 2009-06-03 13:27 EDT (History)
2 users (show)

See Also:
Szymon.Brandys: review+

Attachments
Fix (1.57 KB, patch)
2008-05-15 07:46 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
Fix with test (14.22 KB, patch)
2008-10-13 03:10 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
mylyn/context/zip (22.45 KB, application/octet-stream)
2008-10-13 03:10 EDT, Krzysztof Daniel CLA 		no flags Details
Fix with improved test (14.28 KB, patch)
2008-10-13 03:25 EDT, Krzysztof Daniel CLA 		emoffatt: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2008-05-06 05:33:08 EDT
Comment 1 Krzysztof Daniel CLA 2008-05-15 07:46:05 EDT 
Created attachment 100410 [details]
Fix

Now the default label provider will not dispose cached images while switching modality.

The patch that would solve the general issue (not disposing even custom label providers) is much much bigger and I am afraid unacceptable at current time.

I'd like to work on this after 3.4.
Comment 2 Kevin McGuire CLA 2008-09-26 10:45:01 EDT 
The issue is that we're using the same label provider even though its been disposed. Luckily at present, dispose() doesn't do anything and so the code happens to work.
Comment 3 Krzysztof Daniel CLA 2008-10-13 03:10:02 EDT 
Created attachment 114915 [details]
Fix with test
Comment 4 Krzysztof Daniel CLA 2008-10-13 03:10:08 EDT 
Created attachment 114916 [details]
mylyn/context/zip
Comment 5 Krzysztof Daniel CLA 2008-10-13 03:25:35 EDT 
Created attachment 114920 [details]
Fix with improved test
Comment 6 Szymon Brandys CLA 2008-10-21 06:44:27 EDT 
Released to HEAD with minor changes in javadocs. Thanks Krzysztof.