Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 229641 - Added Extension location repos in UI contain no features
Summary: Added Extension location repos in UI contain no features
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 224012
  Show dependency tree
 
Reported: 2008-04-30 10:56 EDT by Simon Kaegi CLA
Modified: 2008-05-01 11:26 EDT (History)
5 users (show)

See Also:

Attachments
patch (21.84 KB, patch)
2008-04-30 14:34 EDT, DJ Houghton CLA 		no flags Details | Diff
patch (29.74 KB, patch)
2008-04-30 16:50 EDT, DJ Houghton CLA 		no flags Details | Diff
patch (29.48 KB, patch)
2008-04-30 20:16 EDT, DJ Houghton CLA 		no flags Details | Diff
patch (23.57 KB, patch)
2008-05-01 00:06 EDT, Simon Kaegi CLA 		no flags Details | Diff
patch (34.16 KB, patch)
2008-05-01 09:45 EDT, Simon Kaegi CLA 		no flags Details | Diff
patch (34.40 KB, patch)
2008-05-01 10:24 EDT, DJ Houghton CLA 		no flags Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2008-04-30 10:56:32 EDT 
Extension location repos added in the ui validate but will not load correctly and throw a ProvisioningException because they can't find the backing repository. We should either fix validate to ensure that the backing repository is present or else have load create the repository.
Comment 1 Susan McCourt CLA 2008-04-30 11:34:55 EDT 
I think the fix should be in load.
We had to stop contacting the repositories for validation due to bug #225062.
Comment 2 DJ Houghton CLA 2008-04-30 13:55:32 EDT 
We are changing the code so a load will actually load the extension location repository and if it doesn't exist, it will create one with default property values. As a result, we also will be changing the callers to explicitly calling #create first, failing, and then call #load.
Comment 3 DJ Houghton CLA 2008-04-30 14:34:10 EDT 
Created attachment 98237 [details]
patch

Here are changes. Will release after more testing.
Comment 4 DJ Houghton CLA 2008-04-30 16:50:09 EDT 
Created attachment 98264 [details]
patch

Updated patching, including changes to test suites.
Comment 5 DJ Houghton CLA 2008-04-30 18:48:25 EDT 
Simon, we will test this tonight and potentially release tomorrow.
Comment 6 Tim Mok CLA 2008-04-30 18:56:11 EDT 
The patch needs to be updated again since there were some changes to
PlatformXmlListener. I did manage to test using the previous version of it. I
could add an extension location using p2 UI and install what was in there.
Comment 7 DJ Houghton CLA 2008-04-30 20:16:52 EDT 
Created attachment 98282 [details]
patch

ok, here is an update.
Comment 8 Simon Kaegi CLA 2008-05-01 00:06:59 EDT 
Created attachment 98293 [details]
patch

Another update. This one builds on the previous patch and adds additional checks in the ExtensionLocation repos for a pre-existing underlying local repo. I've also brought the createExtensionLocationRepo logic together in the dropins Activator. Both the DropinsRepositoryListener and PlatformXMLListener now use this.
Comment 9 DJ Houghton CLA 2008-05-01 09:30:51 EDT 
Simon, the changes to the test suites are missing from your latest patch. Are there any changes to them or should I grab my changes from the previous patch?
Comment 10 Simon Kaegi CLA 2008-05-01 09:45:17 EDT 
Created attachment 98310 [details]
patch

You're right. This adds back the tests.
Comment 11 DJ Houghton CLA 2008-05-01 10:24:03 EDT 
Created attachment 98315 [details]
patch

Updated patch for review.
Comment 12 DJ Houghton CLA 2008-05-01 11:26:30 EDT 
Modified patch released to HEAD.
Closing.