Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 229364 - [ui] Polish 'Software Updates and Add-Ons' dialog
Summary: [ui] Polish 'Software Updates and Add-Ons' dialog
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-29 11:37 EDT by Martin Aeschlimann CLA
Modified: 2008-05-15 20:22 EDT (History)
4 users (show)

See Also:
Kevin_McGuire: review+


Attachments
page 1 (16.84 KB, image/png)
2008-04-29 11:37 EDT, Martin Aeschlimann CLA
no flags Details
Second page (26.21 KB, image/png)
2008-04-29 11:52 EDT, Martin Aeschlimann CLA
no flags Details
screenshot while adding a site (18.78 KB, image/png)
2008-05-06 05:01 EDT, Martin Aeschlimann CLA
no flags Details
patch to dialog and properties files (12.32 KB, patch)
2008-05-15 17:54 EDT, Susan McCourt CLA
no flags Details | Diff
replacement patch (13.35 KB, patch)
2008-05-15 19:20 EDT, Susan McCourt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2008-04-29 11:37:51 EDT
Created attachment 98003 [details]
page 1

I20080428-1300
WinXP

- Open the Help > 'Software Updates..' action

I would suggest the following UI improvements:

First tab:

1. Align the buttons with the top of the table (as done on most other preference pages)
2. Button names must use title capitalization: 'Check for Updates...', 'Revert Configuration...'
3. The sentence at the bottom is a bit cryptic. Maybe change it to something like 'Open the <a>Update preference page</a> to set an automatic update schedule.'
Comment 1 Martin Aeschlimann CLA 2008-04-29 11:52:19 EDT
Created attachment 98010 [details]
Second page

a. all margins between controls are slightly different
b. remove the indent of the checkboxes, align them with the table
c. labels like 'dropins:' or 'file:' are very technical. Maybe replace them with a top level node
Drop-in folder (c:\dev\....)
   Plugin One
   Plugin Two
Local folders
Update sites
   ECL Emma Update site (..pdate.eclemma.org)
      ECL Emma 1.0
   ASTView update site (url...)
      ASTView 1.0
d. Use colors to make additional information like paths and URLs less dominant
e. Button names must use title capitalization: 'Manage Sites...', 'Remove Sites..'
f. add a confirmation dialog on 'Remove Sites...'. Can I really remove the dropins folder? Add add it again?
Comment 2 Susan McCourt CLA 2008-04-29 12:45:16 EDT
thanks, Martin, marking for 3.4
We will likely address the style-guide type issues for 3.4, and some of the naming issues involve the metadata generated by the repos.
Comment 3 Susan McCourt CLA 2008-04-29 12:49:24 EDT
metadata issues are in bug #221727, also tagged for 3.4.
Comment 4 Martin Aeschlimann CLA 2008-05-06 05:01:23 EDT
Created attachment 98766 [details]
screenshot while adding a site

There's another label with wrong capitalization (see label in front of the progress bar).

Normally the progress label is above the progress bar, not on the left.
Comment 5 Susan McCourt CLA 2008-05-14 15:41:31 EDT
>Normally the progress label is above the progress bar, not on the left.

I agree that is is different, but given that we are already using a lot of horizontal space to show simply animation vs. progress, I don't want to use any more horizontal space for this bar by moving the label.  I see us revisiting our progress/modality issues after 3.4, this progress bar makes people think the updates dialog is a wizard in some ways and made users not realize they could close it (see bug #231590).

Also, in reviewing bug 231590, Kevin and I agreed on a few more button changes that make sense given the evolution of UI restrictions since last review:

- separate the install/uninstall/update buttons from the rest (per bug 231590)
- move "add site" to be above manage sites and keep it in all three views (because you can add a site even if sites aren't visible in the view)
- remove "remove site" from the main view.  It's not common and only applicable when viewing by site.  Rather than having it appear and disappear, drawing attention to it, we will remove it completely.  The user can remove sites from the manage site dialog.
- move refresh to bottom because indeed the user doesn't really know when they need to refresh until they press it.  We don't really want to emphasize it.  When and if we show repo content in the manage sites dialog, it would make sense to move the button there.

So the button order and capitalization will be as follows:

Install...

Properties...

Add Site...
Manage Sites...

Refresh


On the installed page it will be
Update...
Uninstall...

Properties...

Revert Configuration...

Note the change from "Check for updates..." to "Update..."
Since all of the install actions present a confirmation wizard before doing anything, I don't see a reason to treat that fact differently for the update case.
Comment 6 Susan McCourt CLA 2008-05-14 15:41:52 EDT
meant to cc: Kevin
Comment 7 Susan McCourt CLA 2008-05-15 17:54:27 EDT
Created attachment 100559 [details]
patch to dialog and properties files
Comment 8 Susan McCourt CLA 2008-05-15 17:59:49 EDT
Kevin, can you please review this patch?

- changes cap style on buttons 
- changes pref link message and adopts proper quoting
- changes vertical button alignment 
- removes indent from checkboxes
- rearranges buttons per comment #5
- removes ellipsis from Properties... 
- changes "Check for updates" to "Update" 

Did not address capitalization issues in progress bar, these are derived from operation names.  We'll probably rethink this whole in-place progress presentation after 3.4.

Most of those "technical" repo names Martin saw should be fixed by virtue of metadata changes in the sites themselves and visibility bugs we had.
Comment 9 Susan McCourt CLA 2008-05-15 18:09:24 EDT
I added the "missing prompt for remove" issue to bug #218534.
I added the color suggestions to bug #214787

So I think everything is covered and this bug can be closed when the fix is reviewed/released.
Comment 10 Susan McCourt CLA 2008-05-15 19:20:54 EDT
Created attachment 100577 [details]
replacement patch

patch containing several issues discussed with Kevin:

- need breathing margin between top of tab folder page and top of table in installed feature page.  Accomplished by removing special margin settings and just adopting the defaults for vertical margins
- "Remove site..." should be "Remove Site..." in the RemoveColocatedRepository action.  Done for completeness even though that label is overridden in the manage site dialog.
Comment 11 Kevin McGuire CLA 2008-05-15 19:23:00 EDT
+1
Looks much better!
Comment 12 Susan McCourt CLA 2008-05-15 19:24:54 EDT
thanks, Kevin.
committed to HEAD for 20080515 build
Comment 13 Susan McCourt CLA 2008-05-15 20:22:15 EDT
marking fixed.