Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 229305 - [ui] Installing from a filtered selection does not work
Summary: [ui] Installing from a filtered selection does not work
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 229665 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-04-29 09:41 EDT by Pascal Rapicault CLA
Modified: 2008-04-30 18:58 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2008-04-29 09:41:02 EDT
I20080429-0100
Steps to reproduce
(in the site view)
- add the test update site: http://update.eclipse.org/testUpdates
- in the filter search for "releng"
- select the match, and notice that the match and all its parents are selected with the check box.
- click install and notice the error.

It appears like we have tried to install not only the feature but also all the elements from the category thus explaining the error.

What I found weird is that the selection should not have checked the box of the category, but just fill it with a square.
Comment 1 Susan McCourt CLA 2008-04-29 11:00:15 EDT
This may be a timing problem between the checkbox container code and the filtering code.  Will investigate after test pass for M7.
Comment 2 Susan McCourt CLA 2008-04-29 18:25:42 EDT
>What I found weird is that the selection should not have checked the box of the
>category, but just fill it with a square.

when the filtering job resets the viewer content, we need to catch this and invoke the check state changed listener so that the check state of the parent containers can be reset accordingly.  Right now the code that manages the check boxes has no idea that filtering occurred and it only knows about the old check state.
Comment 3 Susan McCourt CLA 2008-04-30 13:19:47 EDT
*** Bug 229665 has been marked as a duplicate of this bug. ***
Comment 4 Susan McCourt CLA 2008-04-30 15:16:59 EDT
Note for future...this is a similar problem found in
bug 17907
bug 170521
	

Comment 5 Susan McCourt CLA 2008-04-30 18:58:30 EDT
Marking this bug fixed.
What I fixed was the problem of considering all of the filtered IU's selected and opening up the wizard on the wrong set of items. 

What remains are a bunch of selection oddities involving the check marks when you filter and unfilter the list.  I believe these to ultimately result from bogus assumptions made in ContainerCheckedTreeViewer about the state of its elements when preserving selections.

I spent the better part of this afternoon trying different workarounds and each introduced its own new set of problems.  So for M7, I'm not working around these issues.  I opened bug 229735 to track this part of the problem and will give it another look early in RC1.