Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 229177 - some changes to service model for consumability by RDT back-end
Summary: some changes to service model for consumability by RDT back-end
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: 2.1M2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.1   Edit
Assignee: Greg Watson CLA
QA Contact: Greg Watson CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-28 16:45 EDT by Chris Recoskie CLA
Modified: 2011-01-31 08:13 EST (History)
1 user (show)

See Also:

Attachments
proposed patch (6.87 KB, patch)
2008-04-28 16:45 EDT, Chris Recoskie CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Recoskie CLA 2008-04-28 16:45:52 EDT 
Created attachment 97850 [details]
proposed patch

I found I needed these changes while I was working on creating the remote backend and client side plumbing for RDT.

- The service model manager has no way to get an IService for a given service ID
- ServiceModelManager should be a singleton
- ServiceProviderDescriptor should be API, not internal, as this allows provider implementations to reuse boilerplate code for tracking provider names, service IDs, etc.

I've attached a patch for the above for consideration.
Comment 1 Greg Watson CLA 2008-04-28 17:00:35 EDT 
Looks good to me. Committed.
Comment 2 Jason Montojo CLA 2008-04-29 00:07:17 EDT 
Hi Greg,

I don't see the changes in CVS.  I've got the HEAD branch of the following checked out into my workspace:

org.eclipse.ptp/rdt/org.eclipse.ptp.rdt.services

Is that the right module?
Comment 3 Chris Recoskie CLA 2008-04-29 08:58:11 EDT 
(In reply to comment #2)
> Hi Greg,
> I don't see the changes in CVS.  I've got the HEAD branch of the following
> checked out into my workspace:
> org.eclipse.ptp/rdt/org.eclipse.ptp.rdt.services
> Is that the right module?

Ditto
Comment 4 Greg Watson CLA 2008-04-29 10:00:26 EDT 
It's in the 2.0 branch. I'll merge with HEAD as soon as I get this release out today.
Comment 5 Greg Watson CLA 2008-05-02 16:29:04 EDT 
Merged with HEAD.