Community
Participate
Working Groups
Currently, copying a file from the windows explorer and pasting it into a performance test project in the test navigator fails, the following NPE being raised: java.lang.NullPointerException at org.eclipse.hyades.test.ui.internal.navigator.action.FileAndFolderPaster.sortClipboardElements(FileAndFolderPaster.java:62) at org.eclipse.hyades.test.ui.internal.navigator.action.FileAndFolderPaster.performPaste(FileAndFolderPaster.java:99) at org.eclipse.hyades.test.ui.internal.navigator.action.PasteAction.run(PasteAction.java:65) ... ... Work-around: either use the Import > File system feature, or paste the copied file into another view like the navigator or the project explorer.
tested it with latest tptp version, and nothing can raise such exception at this line there was such kind of bug with first delivery of 166025 patch but this was fixed some time ago (see bugzilla 166025, comment 63, under CVS since 4/11/08) problem was an empty clipboard that raised this exception.
Using the TPTP M5 driver, files could be copied from Window Explorer/Desktop and pasted in the Test Navigator. Using the TPTP M7 driver, there is no NullPointerException when pasting files in the Test Navigator that were copied from Window Explorer/Desktop. However, the files are not pasted successfully in the Test Navigator and the enclosed dialog appears. As such, increasing the severity since this is a regression of function.
Created attachment 97787 [details] Screen capture. We need to fix this problem as well as the size of the informational dialog.
Created attachment 98127 [details] fix for external copy paste this patch fix the external copy/paste (copy from windows explorer for example and paste inside test navigator)
worked hours updated
Created attachment 98209 [details] manual test for external copy/paste bug
Patch reviewed and approved with comments: 1) In org.eclipse.hyades.test.ui.internal.navigator.refactoring.PasteFileChange.PasteFileChange(IFile, IContainer), there is no need for: + this.externalFileName = null; 2) In org.eclipse.hyades.test.ui.internal.navigator.refactoring.PasteFileChange.perform(IProgressMonitor), we should handle the FileNotFoundException/IOException by displaying an error message and log the error to the .log file. 3) Please add a class comment to ReferenceDisplayUtils.
(In reply to comment #6) > Created an attachment (id=98209) [details] > manual test for external copy/paste bug > Please change the name of this test suite to Test.UI.TestNavigator_bugzilla_228991.testsuite (requires a file and logical rename) and add a test invocation to the behavior to org.eclipse.hyades.test.ui.navigator.tests/manual/AllTests.testsuite.
Created attachment 98223 [details] cleaned patch same patch but cleaned following Paul review
(In reply to comment #9) > Created an attachment (id=98223) [details] > cleaned patch > > same patch but cleaned following Paul review > This patch cannot be integrated since it contains the wrong strings in the error dialog: new ErrorDialog(Display.getDefault().getActiveShell(), + UiPluginResourceBundle.WIZ_DATAPOOL_CSV_ERRDLG_TITLE, + UiPluginResourceBundle._ERROR_WIZ_DATAPOOL_CSV_ERRDLG_IMPFILE, + new Status(IStatus.ERROR, + UiPlugin.PLUGIN_ID, + IStatus.OK, + e.toString(), + e),IStatus.ERROR).open(); These are the datapool error dialog strings.
Created attachment 98224 [details] cleaned patch cleaned some misused externalized string
(In reply to comment #11) > Created an attachment (id=98224) [details] > cleaned patch > > cleaned some misused externalized string > Approved. Please integrate.
pushed under CVS
closing
