Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 228931 - Errors being logged when connecting to local update site without digest
Summary: Errors being logged when connecting to local update site without digest
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-25 14:40 EDT by DJ Houghton CLA
Modified: 2008-04-25 16:09 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2008-04-25 14:40:52 EDT
I am trying to install something from a local update site (file:) and I don't have a digest file. I am seeing this error in my log file.

There is code in UpdateSite#loadFeaturesFromDigest which used to ignore a FileNotFoundException. We should update the new adoption of ECF to behave in a similar manner.


osgi> !SESSION 2008-04-25 14:25:42.642 -----------------------------------------------
eclipse.buildId=N20080423-2000
java.version=1.5.0_08
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US
Command-line arguments:  -os win32 -ws win32 -arch x86 -console -consoleLog

!ENTRY org.eclipse.equinox.p2.metadata.generator 4 0 2008-04-25 14:27:26.511
!MESSAGE Error reading site digest C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\digest13303.zip.
!STACK 0
java.util.zip.ZipException: error in opening zip file
        at java.util.zip.ZipFile.open(Native Method)
        at java.util.zip.ZipFile.<init>(Unknown Source)
        at java.util.jar.JarFile.<init>(Unknown Source)
        at java.util.jar.JarFile.<init>(Unknown Source)
        at org.eclipse.equinox.internal.p2.metadata.generator.features.DigestParser.parse(DigestParser.java:75)
        at org.eclipse.equinox.internal.p2.updatesite.UpdateSite.loadFeaturesFromDigest(UpdateSite.java:323)
        at org.eclipse.equinox.internal.p2.updatesite.UpdateSite.loadFeatures(UpdateSite.java:306)
        at org.eclipse.equinox.internal.p2.updatesite.metadata.UpdateSiteMetadataRepository.generateMetadata(UpdateSiteMetadataRepository.java:105)
        at org.eclipse.equinox.internal.p2.updatesite.metadata.UpdateSiteMetadataRepository.<init>(UpdateSiteMetadataRepository.java:70)
        at org.eclipse.equinox.internal.p2.updatesite.metadata.UpdateSiteMetadataRepositoryFactory.load(UpdateSiteMetadataRepositoryFactory.java:47)
        at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.loadRepository(MetadataRepositoryManager.java:443)
        at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.loadRepository(MetadataRepositoryManager.java:419)
        at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.loadRepository(MetadataRepositoryManager.java:404)
        at org.eclipse.equinox.internal.provisional.p2.ui.operations.ProvisioningUtil.loadMetadataRepository(ProvisioningUtil.java:71)
        at org.eclipse.equinox.internal.provisional.p2.ui.dialogs.AvailableIUGroup.makeRepositoryVisible(AvailableIUGroup.java:381)
        at org.eclipse.equinox.internal.provisional.p2.ui.dialogs.AvailableIUGroup$2.repositoryAdded(AvailableIUGroup.java:258)
        at org.eclipse.equinox.internal.provisional.p2.ui.viewers.StructuredViewerProvisioningListener.notify(StructuredViewerProvisioningListener.jav
a:81)
        at org.eclipse.equinox.internal.p2.core.ProvisioningEventBus.dispatchEvent(ProvisioningEventBus.java:86)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:211)
        at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:141)
        at org.eclipse.equinox.internal.p2.core.ProvisioningEventBus.publishEvent(ProvisioningEventBus.java:71)
        at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.broadcastChangeEvent(MetadataRepositoryManager.java:148)
        at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.addRepository(MetadataRepositoryManager.java:139)
        at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.addRepository(MetadataRepositoryManager.java:122)
        at org.eclipse.equinox.internal.provisional.p2.ui.operations.ProvisioningUtil.addMetadataRepository(ProvisioningUtil.java:43)
        at org.eclipse.equinox.internal.provisional.p2.ui.operations.AddColocatedRepositoryOperation.doBatchedExecute(AddColocatedRepositoryOperation.
java:37)
        at org.eclipse.equinox.internal.provisional.p2.ui.operations.RepositoryOperation.doExecute(RepositoryOperation.java:63)
        at org.eclipse.equinox.internal.provisional.p2.ui.operations.UndoableProvisioningOperation.execute(UndoableProvisioningOperation.java:77)
        at org.eclipse.core.commands.operations.DefaultOperationHistory.execute(DefaultOperationHistory.java:511)
        at org.eclipse.equinox.internal.provisional.p2.ui.ProvisioningOperationRunner$1.run(ProvisioningOperationRunner.java:93)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Comment 1 Simon Kaegi CLA 2008-04-25 15:49:08 EDT
Also see bug 228198 -- we may be able to avoid the FNF logic altogether.
Comment 2 John Arthorne CLA 2008-04-25 16:09:39 EDT
Fixed.