Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 228794 - [ui] "Include items that have already been installed" checkbox does not work properly
Summary: [ui] "Include items that have already been installed" checkbox does not work ...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 229378 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-04-24 19:06 EDT by Cheng-Yee Lin CLA
Modified: 2008-05-01 00:49 EDT (History)
3 users (show)

See Also:


Attachments
Installed items are still displayed when the checkbox is unchecked. (89.37 KB, image/pjpeg)
2008-04-28 18:04 EDT, Cheng-Yee Lin CLA
no flags Details
The items in the installed software tab (86.49 KB, image/pjpeg)
2008-04-28 18:43 EDT, Cheng-Yee Lin CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cheng-Yee Lin CLA 2008-04-24 19:06:15 EDT
Build: eclipse SDK I20080422-0800

The "Include items that have already been installed" checkbox on the Available Software tab of the Software Updates dialog does not work properly when the "View by" selection is "Site" or "Category".  It does work when the "view by" selection is "Name".
Comment 1 Susan McCourt CLA 2008-04-24 21:41:22 EDT
investigate for M7, this was working earlier.
Comment 2 Susan McCourt CLA 2008-04-28 12:33:32 EDT
Can you please provide more information?  This is working as expected for me.
Note that the site and categories will always show, even if all content is installed. So if site X has category Y, with feature Z, and feature Z is installed, you will still see 
Site X
  Category Y

in the list.  When the "include installed features checkbox is checked, you'll see:

Site X
  Category Y
    Feature Z




Comment 3 Cheng-Yee Lin CLA 2008-04-28 18:03:39 EDT
The issue is around what should not be displayed when the checkbox is "unchecked".  For View by "Name", it displays only the uninstalled items, which is the correct behavior.  However, For View by "Category" or "Site", the installed items are also displayed.  The attached screenshot is an example (only the EMF items should be displayed in this case.)

Still a problem in the I20080427-1857 build.
Comment 4 Cheng-Yee Lin CLA 2008-04-28 18:04:33 EDT
Created attachment 97872 [details]
Installed items are still displayed when the checkbox is unchecked.
Comment 5 Susan McCourt CLA 2008-04-28 18:10:33 EDT
Are those the exact versions of what you have installed?

Can you please export the repositories you are connected to (manage sites...export...) and attach the xml file here?  

I can't reproduce the problem.  In any view (site, category, name), the only time I see any SDK features shown are when there are versions that are different than what I have installed (and only newer version if the other check box is checked).  This would be expected.
Comment 6 Cheng-Yee Lin CLA 2008-04-28 18:43:19 EDT
Created attachment 97874 [details]
The items in the installed software tab

I just attached the screen shot for the installed software tab which shows the same versions of those items.  (I can't quite for a way to export the data.  I had Dave S. over to take a look, and he couldn't figure it out, either.)
Comment 7 Susan McCourt CLA 2008-04-28 19:50:05 EDT
I think it's best if we have you try this again on the M7 test candidate (whatever 0429 build is declared the test candidate).  The fact that all of those features are in your installed software list is a bug in itself, something fixed today in the platform reconciler (only the SDK root item should be shown). 

I'm not sure the behavior is causing the bug, but I just want to compare to apples to apples.

>(I can't quite for a way to export the data.  I
>had Dave S. over to take a look, and he couldn't figure it out, either.)

Hmmm...I would expect it would have showed up in the 427 build, but I didn't download that one.  If it's in the build, you should see...

Help>Software Updates>
Available Software Tab
Manage Sites... button
Export...

It is definitely in the 0428 builds.

At any rate, if you can try again on an 0429 build and report back, and include the site export, I would appreciate it.
Comment 8 Susan McCourt CLA 2008-04-29 14:15:15 EDT
I can see this now on I20090429-0100, Win XP.
I installed releng tools, and in the site/category views, I see releng tools in the filter even when the checkbox is unchecked.  In the name view, it does not show.  The versions are identical.
Comment 9 Andrew Overholt CLA 2008-04-29 17:19:49 EDT
*** Bug 229378 has been marked as a duplicate of this bug. ***
Comment 10 Susan McCourt CLA 2008-04-30 23:38:49 EDT
Today while working on another bug I spent quite a lot of time filtering "rel" and seeing releng tools.  At some point during my testing, releng disappeared.  I thought something weird was going on, then realized I had releng installed and the [] Include items installed checkbox unchecked.  So it should have never been showing.  So presumably I had this bug at some point today.

But now I try to reproduce it and can't.  No matter which view I'm in, I do not see the releng tools when I uncheck the box, and I see releng tools when I check the box.  As expected.  I tried from all three views with the "Show latest version" checkbox in both states.  Seems to be working fine.

I think either something has changed underneath me (like an implementation of equals in some IInstallableUnit implementor), or else there is some set of steps you have to go through to see the bug. 

It seems like when you have the bug, it's ever-present and obvious, and when it's gone it's gone, and I don't know what conditions cause it.
Comment 11 Susan McCourt CLA 2008-05-01 00:02:50 EDT
note to self:  
It's possible that one of the elements or queries is holding onto an old profile instance.  If this were true, then after installing releng tools, you might always see releng tools if the profile snapshot being held reflected the state of the world before the installation.  
Comment 12 Susan McCourt CLA 2008-05-01 00:09:18 EDT
hmmm...now I'm starting to think I've only ever seen this in the "Uncategorized" category, and there is special handling of this case.  If anyone has seen it in another category, please let me know.
Comment 13 Susan McCourt CLA 2008-05-01 00:49:08 EDT
Fixed in HEAD >20080430.
It was indeed a problem specific to the uncategorized category, which was not set up with the instruction to ignore installed content.