This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 228742 - Local and Remote Component interface not shown in EJB 3.0 DD tree
Summary: Local and Remote Component interface not shown in EJB 3.0 DD tree
Status: CLOSED FIXED
Alias: None
Product: WTP EJB Tools
Classification: WebTools
Component: jst.ejb (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC1   Edit
Assignee: Dimitar Giormov CLA
QA Contact: Kaloyan Raev CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-24 14:58 EDT by Kaloyan Raev CLA
Modified: 2008-05-19 07:01 EDT (History)
2 users (show)

See Also:
kaloyan: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
kaloyan: pmc_approved? (naci.dai)
kaloyan: pmc_approved? (deboer)
kaloyan: pmc_approved? (neil.hauge)
kaloyan: review+


Attachments
fixed missing Component interfaces. (2.69 KB, patch)
2008-05-13 08:03 EDT, Dimitar Giormov CLA
no flags Details | Diff
try catch for core exception added. (3.44 KB, patch)
2008-05-15 07:34 EDT, Dimitar Giormov CLA
kaloyan: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2008-04-24 14:58:21 EDT
If I create a Session Bean v3.0 with checked options for creating EJB 2.x component and home interfaces, the component interfaces are not shown in the deployment descriptor tree in the Project Navigator. These interfaces are shown for EJB 2.1 projects.
Comment 1 Dimitar Giormov CLA 2008-05-13 08:03:46 EDT
Created attachment 99928 [details]
fixed missing Component interfaces.

Component interfaces were missed by the annotation factory, they should have been created when the home interface artifact is set in the model.
Comment 2 Kaloyan Raev CLA 2008-05-13 08:28:24 EDT
Patch looks fine.
All changes are in internal code of the ejb model. 
The changes are small and I have tested them manually. 

Requesting PMC review for RC1. 
Comment 3 Raghunathan Srinivasan CLA 2008-05-13 16:39:10 EDT
Approved.
Comment 4 Kaloyan Raev CLA 2008-05-14 04:33:08 EDT
committed to HEAD and released to build. 
Comment 5 Dimitar Giormov CLA 2008-05-15 07:32:06 EDT
junit tests failed because of this fix.

While trying to extract information about Local or Remote Component interfaces CoreException could occur and the Bean is not created.

I have added try-catch block for the exception, which solves the issue.
Comment 6 Dimitar Giormov CLA 2008-05-15 07:34:21 EDT
Created attachment 100409 [details]
try catch for core exception added.
Comment 7 Kaloyan Raev CLA 2008-05-15 07:38:07 EDT
Comment on attachment 100409 [details]
try catch for core exception added.

The fix looks OK for me. 
Dimitar, please commit the patch and release it to build. 
Then inform wtp-releng mailing list for this issue.
Comment 8 Dimitar Giormov CLA 2008-05-15 07:58:05 EDT
dropped in head.

JUnit tests passed successfully on my local PC.
Comment 9 Kaloyan Raev CLA 2008-05-19 07:01:41 EDT
Verified with the S-3.0RC1-20080516071848 build.