Community
Participate
Working Groups
The "Alt + Enter" key combo is not opening the breakpoint properties for Java breakpoints. The action is invoked, but it has no "active" breakpoint. It appears the action is not getting selection change notifications.
Moving to Platform UI for comment. When just changing the selection in the view, the action never receives selection change notifications. If I right click, two calls to selectionChanged() are made, one with an empty selection and then one with a proper selection. This allows the action to work correctly if the action is invoked from the context menu. Even if I use right clicking to update the action, invoking it using the Alt-Enter keybinding always fails, because before run() is called, there is an additional call to selectionChanged() with a null selection.
Darin, which build are you using ? I'll pass it to Paul for a look...
I20080422
What's the FQ class name for your action? I'll take a look at this soon. PW
org.eclipse.jdt.internal.debug.ui.actions.JavaBreakpointPropertiesAction
Created attachment 99089 [details] Action Delegate v01 the context menu variables sources now return IEvaluationContext.UNDEFINED_VARIABLE when they are not set and it was overriding a casual selection. That's why it worked from the context menu. PW
*** Bug 228405 has been marked as a duplicate of this bug. ***
Eric, could you please take a look? PW
Looks good...
Released to HEAD for I20080507-2000 PW
Paul's patch seems to fix all the issues related to Team/CVS actions gathered in bug 228405. Thanks!
Regarding the commit action, there is still a problem, at least in RC3: The keyboard shortcut works perfectly fine, if I use it while the project is selected. However, it does not work, if the topmost package is selected. Selecting other packages seem to work, at least in a quick test.
Please open a new bug with a reproducible test case on RC4 ... commit is not ALT+ENTER. PW
I am still having issues with this in the 3.4 release. I am finding that the Team/commit keyboard shortcut works intermittently. In my most recent test using the C/C++ projects view: - selecting one file with changes and pressing the commit shortcut works. - selecting its parent folder and pressing the shortcut gives a "the selected resources do not contain any changes" - selecting a second file with pending changes in a different folder gives the same error message (even though the file does contain changes and is annotated as such). - pressing the commit shortcut of the parent folder of this file also gives the same error message. - Using the commit shortcut on these same 4 resources in the Package Explorer view opens the commit dialog as expected. However, I have previously experienced the same problems using Project Explorer. Joe.
(In reply to comment #14) I've opened Bug 243740 to track this issue. PW
