Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 228671 - [Annotate] Support moving mouse into revision hover
Summary: [Annotate] Support moving mouse into revision hover
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M7   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-24 09:42 EDT by Markus Keller CLA
Modified: 2008-04-30 05:11 EDT (History)
2 users (show)

See Also:


Attachments
Fix (14.03 KB, patch)
2008-04-24 09:42 EDT, Markus Keller CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-04-24 09:42:33 EDT
Created attachment 97457 [details]
Fix

I improved the annotation hovering support in text editors, such that the user can now also move the mouse into hovers from the annotation and overview rulers (only in HEAD). With this support, the quick diff change hovers already support moving the mouse into quick diff hovers.

Unfortunatley, this does not work for the CVS revision information hovers that show up on "Team > Show Annotations", because they use their own SourceViewerInformationControl.

The attached patch removes your copy of SourceViewerInformationControl and uses a DefaultInformationControl instead (which implements the "move into" support for free). You can release this at any time, but the "move into" feature will only work with Platform/Text from HEAD.

Another advantage of DefaultInformationControl is that it becomes easy to add a toolbar to the hover, e.g. with buttons to jump to the History view, to jump to previous/next block from the same commit, or to open a compare editor for the whole file that shows the selected block in context. I'll file another bug for this as soon as I find some time to implement it.
Comment 1 Tomasz Zarna CLA 2008-04-25 08:17:45 EDT
Indeed, this works as expected only with the freshest Platform/Text, but I won't hold off with releasing the patch. Thanks a lot, Markus.
Comment 2 Tomasz Zarna CLA 2008-04-25 08:23:01 EDT
Patch applied to CVS HEAD.
Comment 3 Tomasz Zarna CLA 2008-04-30 05:11:53 EDT
Verified in I20080429-0100. Thanks again Markus.