Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 228405 - 'Show Annotation' command does not work any more
Summary: 'Show Annotation' command does not work any more
Status: RESOLVED DUPLICATE of bug 228717
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 229713 230294 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-04-23 09:27 EDT by Markus Keller CLA
Modified: 2008-05-07 10:54 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-04-23 09:27:04 EDT
I20080422-0800, was OK in I20080415-1646

The 'Show Annotation' command does not work any more:
- new workspace
- bind 'Show Annotation' to Alt+Shift+A
- in the Package Explorer, select or open a file from CVS
- Alt+Shift+A
=> "operation is not enabled" dialog
=> should show annotations
Comment 1 Tomasz Zarna CLA 2008-04-23 09:58:18 EDT
Markus, you are able to ask for annotation using the context menu, aren't you? There is a problem with calling the command using a key binding, right?
Comment 2 Markus Keller CLA 2008-04-23 10:06:19 EDT
> Markus, you are able to ask for annotation using the context menu, aren't you?
> There is a problem with calling the command using a key binding, right?

Yes, but I forgot where the command is located in the menu ;-).

I marked it as Major because I didn't see any changes in that area, which makes me fear the problem could also affect other commands. It could also be a problem in Platform/UI, but it needs to be investigated.
Comment 3 Tomasz Zarna CLA 2008-04-23 10:19:00 EDT
(In reply to comment #2)
> Yes, but I forgot where the command is located in the menu ;-).

Forgiven ;)

> It could also be a problem in Platform/UI, but it needs to be investigated.

That's my main suspect too.
Comment 4 Tomasz Zarna CLA 2008-04-24 09:10:20 EDT
I have key bindings for Commit and Update commands. When trying to use one of them I get the same dialog as described in comment 0. Picking the action from the context menu executes it normally. If I find out this can happen to an action not related to Compare/Team/CVS I will move the to Platform/UI. Until then, assigning to myself to investigate.
Comment 5 Tomasz Zarna CLA 2008-05-07 05:55:14 EDT
*** Bug 230294 has been marked as a duplicate of this bug. ***
Comment 6 Tomasz Zarna CLA 2008-05-07 05:59:04 EDT
*** Bug 229713 has been marked as a duplicate of this bug. ***
Comment 7 Tomasz Zarna CLA 2008-05-07 06:04:49 EDT
Bug 229713 informs about problem with using binded "Synchronize with Repository" command in Java Perspective/Package Explorer.
Comment 8 Tomasz Zarna CLA 2008-05-07 06:11:30 EDT
 (In reply to comment #4)
> I have key bindings for Commit and Update commands. When trying to use one of
> them I get the same dialog as described in comment 0. Picking the action from
> the context menu executes it normally.

This happens only when executing the key sequence while in Package Explorer, it works fine when called in Synchronize view.
Comment 9 Tomasz Zarna CLA 2008-05-07 09:49:56 EDT
After some investigation I realized it looks pretty much the same as bug 228717. I'm keeping my fingers crossed for Paul.
Comment 10 Paul Webster CLA 2008-05-07 10:53:21 EDT

*** This bug has been marked as a duplicate of bug 228717 ***
Comment 11 Tomasz Zarna CLA 2008-05-07 10:54:48 EDT
Just for the record, I did some debugging and I found one that when I try to call an action using a key binding ActionDelegateHandlerProxy is used. In its updateDelegate method it tries to get the current selection based on IEvaluationContext. The method does return an object but it's not an instance of ISelection, so in result we get null as selection. I hope this helps.