This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 228268 - Provide icons for dialog box throughtout the ui
Summary: Provide icons for dialog box throughtout the ui
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Cosmos (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Martin D Simmonds CLA
QA Contact:
URL:
Whiteboard: useability
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-22 15:54 EDT by Sheldon Lee-Loy CLA
Modified: 2012-01-03 13:46 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sheldon Lee-Loy CLA 2008-04-22 15:54:34 EDT
It would be nice to show an icon in the top left corner of a dialog box.  This will enhance the look and feel of the COSMOS UI
Comment 1 Sheldon Lee-Loy CLA 2008-04-24 14:27:55 EDT
Moving to i11 since this will improve useabillity and doesn't require alot of changes.
Comment 2 Sheldon Lee-Loy CLA 2008-05-01 15:19:04 EDT
Changing to marting as discussed in our meetings
Comment 3 Martin D Simmonds CLA 2008-05-30 05:47:37 EDT
Added Icon to the Record Details Dialog.  Its the same icon as the icon that is pressed to get the dialog up.  Its hard-coded into RecordDetailsDialog.js, as we have not defined what icon should be used, and where we should pick them up from.   I think we could in i12 create an icons directory that we pick things up from.

I still have to add an icon to the other dialogs.
Comment 4 Martin D Simmonds CLA 2008-05-30 05:49:08 EDT
I had to remove RecordDetailDialog.js from the components directory as it is supposed to be in the widgets directory.  If I did not remove it, then its the one that is picked up.
Comment 5 Martin D Simmonds CLA 2008-05-30 05:57:51 EDT
There is an images Directory. But I think we should create a separate icons directory.  I have seen many products that distinguish between images and icons, even though they are all images.  I suggest we create an ER to add an ICONS directory and at the same time we update all the hard coded dialogue icons to point to the icons directory.  I see the hard-coding as still staying in the js file, and the js file having the ability to set programatically the icon required.
Comment 6 Martin D Simmonds CLA 2008-05-30 05:59:45 EDT
Dialog boxes :

Dialog.html
RecordDetailsDialog.html
RegisterDialog.html
RegisterPartialDialog.html
RegisterResponseDialog.html
Comment 7 Martin D Simmonds CLA 2008-05-30 06:03:45 EDT
Add QueryBuilder.html to the list of dialogs.  Perhaps all dialogs should have the name Dialog in it? If we eventually change this to a floating pane, that then changes things.
Comment 8 Martin D Simmonds CLA 2008-05-30 06:48:38 EDT
Query Builder Icon changes added to CVS.  I used the same icon that the mdr in the DM Tree has.
Comment 9 Martin D Simmonds CLA 2008-06-06 09:19:12 EDT
Checked in changes.
Comment 10 Sheldon Lee-Loy CLA 2008-06-20 15:45:46 EDT
Verified bug with build COSMOS-1.0.0-200806201443
Comment 11 Srinivas Reddy CLA 2008-06-26 03:18:41 EDT
QA review for JUnits/Manual tests:
* No explicit tests provided, however this has been tested as part of End2End
testing based on http://wiki.eclipse.org/COSMOS_DEMO_i11
Comment 12 Sheldon Lee-Loy CLA 2008-07-28 13:10:59 EDT
Marked as closed based on previous comments.