Comment 1 Giedrius Noreikis 2008-11-28 16:29:24 EST

Dear Kevin,

a separate "jfacefonts_windowsvista.properties" is needed for Windows Vista:
1. We have jfacefonts for all the platforms - why Vista should be an exception;
2. I don't understand how fallback to XP properties should happen. On my Windows Vista system "MS Sans Serif" font is being used for Wizard headers and etc. (clearly because of fallback to jfacefonts.properties). Because of this, some non-ASCII characters (e.g. Lithuanian "š" letter) are not displayed properly. Some other posts (e.g. http://dev.eclipse.org/newslists/news.eclipse.platform/msg71142.html) seem to describe the same problem.

Copying "jfacefonts_windowsxp.properties" to "jfacefonts_windowsvista.properties" solves the problem, but I don't think this should be done in applications.

Either a working defaulting to "jfacefonts_windowsxp.properties" or a separate "jfacefonts_windowsvista.properties" file should be provided.

Regards,
Giedrius

Comment 2 Kevin McGuire 2008-12-01 16:34:56 EST

(In reply to comment #1)
Thanks Giedrius.  I agree, seems we should have.  Next question is, what should the values be.  I'm not sure they should be identical to XP, some investigation needed.

Comment 3 Kit Lo 2009-10-26 14:54:08 EDT

Any updates on this?

Comment 4 Remy Suen 2009-10-26 14:59:15 EDT

Do we need a Windows 7 properties file too?

Comment 5 Kit Lo 2009-10-26 15:11:54 EDT

I opened a separate bug 293356 to request jfacefonts properties file for Windows 7.

Comment 6 Giedrius Noreikis 2011-03-23 16:53:24 EDT

Created attachment 191793 [details]
Incorrect double quotes with the default font map

Comment 7 Giedrius Noreikis 2011-03-23 16:54:47 EDT

Created attachment 191794 [details]
Correct double quotes with the Windows 7 font map

Comment 8 Giedrius Noreikis 2011-03-23 16:55:42 EDT

Created attachment 191795 [details]
Correct double quotes with the Windows XP font map

Comment 9 Giedrius Noreikis 2011-03-23 17:00:51 EDT

(In reply to https://bugs.eclipse.org/bugs/show_bug.cgi?id=311037#c20)
My colleague did some tests on Vista. The screenshots are attached: 1) with the default font map; 2) with the Windows 7 font map; 3) with the Windows XP font map.
I think the values from the Windows 7 font properties file can be safely used on Vista.

Comment 10 Susan McCourt 2011-03-29 14:06:07 EDT

(In reply to comment #9)
> (In reply to https://bugs.eclipse.org/bugs/show_bug.cgi?id=311037#c20)
> My colleague did some tests on Vista. The screenshots are attached: 1) with the
> default font map; 2) with the Windows 7 font map; 3) with the Windows XP font
> map.
> I think the values from the Windows 7 font properties file can be safely used
> on Vista.

Thanks for checking this, Giedrius.
I see from the snaps that this solves the specific problem in bug 311037.
Did your colleague also verify that the editor fonts look correct (we use the Consolas font in the win7 file).

If we can verify this, then I think we should release the change soon so that any problems can be found prior to M7 freeze.

Comment 11 Giedrius Noreikis 2011-03-30 17:39:03 EDT

Created attachment 192232 [details]
Editor: Incorrect double quotes with the default font map

Comment 12 Giedrius Noreikis 2011-03-30 17:39:56 EDT

Created attachment 192233 [details]
Editor: Correct double quotes with the Windows 7 font map

Comment 13 Giedrius Noreikis 2011-03-30 17:41:11 EDT

Created attachment 192235 [details]
Editor: Correct double quotes with the Windows XP font map

Comment 14 Giedrius Noreikis 2011-03-30 17:42:08 EDT

(In reply to comment #10)
> Did your colleague also verify that the editor fonts look correct (we use the
> Consolas font in the win7 file).
There are the results of the additional tests with the editor fonts: 1) with the
default font map; 2) with the Windows 7 font map; 3) with the Windows XP font
map.

Comment 15 Lila Aravopoulos 2011-04-05 15:12:17 EDT

(In reply to comment #14)
> (In reply to comment #10)
> > Did your colleague also verify that the editor fonts look correct (we use the
> > Consolas font in the win7 file).
> There are the results of the additional tests with the editor fonts: 1) with
> the
> default font map; 2) with the Windows 7 font map; 3) with the Windows XP font
> map.

(In reply to comment #14)
> (In reply to comment #10)
> > Did your colleague also verify that the editor fonts look correct (we use the
> > Consolas font in the win7 file).
> There are the results of the additional tests with the editor fonts: 1) with
> the
> default font map; 2) with the Windows 7 font map; 3) with the Windows XP font
> map.

Hi, is this bug targeted for Eclipse 3.7? I am asking since the bug is opened against Eclipse 3.4 but the target milestone is 3.7 M7. Thanks

Comment 16 Boris Bokowski 2011-04-06 08:30:12 EDT

(In reply to comment #15)
> Hi, is this bug targeted for Eclipse 3.7? I am asking since the bug is opened
> against Eclipse 3.4 but the target milestone is 3.7 M7. Thanks

Yes, it is targeted to be fixed in the 3.7 (Indigo) release.

Comment 17 Susan McCourt 2011-04-18 13:31:31 EDT

Giedrus, since I'm trying to make this change "blind" (without a vista box), I need to know the exact the name of the file to be used.  (ie, the "os.name" system property when running on vista.)

Is it 

jfacefonts_windowsvista.properties  (my guess)

or is it literally as specified in the bug title here?

jfacefonts_vista.properties (this would surprise me a bit)

Comment 18 Susan McCourt 2011-04-18 13:33:25 EDT

Just reread comment 1.
(In reply to comment #1)
> Dear Kevin,
> 
> a separate "jfacefonts_windowsvista.properties" is needed for Windows Vista:
> 1. We have jfacefonts for all the platforms - why Vista should be an exception;
> 2. I don't understand how fallback to XP properties should happen. On my
> Windows Vista system "MS Sans Serif" font is being used for Wizard headers and
> etc. (clearly because of fallback to jfacefonts.properties). Because of this,
> some non-ASCII characters (e.g. Lithuanian "š" letter) are not displayed
> properly. Some other posts (e.g.
> http://dev.eclipse.org/newslists/news.eclipse.platform/msg71142.html) seem to
> describe the same problem.
> 
> Copying "jfacefonts_windowsxp.properties" to
> "jfacefonts_windowsvista.properties" solves the problem, but I don't think this
> should be done in applications.
> 
> Either a working defaulting to "jfacefonts_windowsxp.properties" or a separate
> "jfacefonts_windowsvista.properties" file should be provided.

To be clear, we are proposing to copy

jfacefonts_window7.properties

to

jfacefonts_windowsvista.properties

Comment 19 Susan McCourt 2011-04-18 13:36:38 EDT

Created attachment 193504 [details]
patch which includes new font file

a patch is worth 1000 words.
Giedrus, can you please verify that this is the proposed solution.

Comment 20 Giedrius Noreikis 2011-04-19 08:19:35 EDT

> need to know the exact the name of the file to be used.  (ie, the "os.name"
> system property when running on vista.)

System.getProperty("os.name") returns "Windows Vista" when running on Vista, so the name of the file must be jfacefonts_windowsvista.properties. 

The patch looks ok. Susan, thank you for your efforts.

Comment 21 Susan McCourt 2011-04-19 12:10:25 EDT

fixed in HEAD >20110419.
Giedrius, I will ping here when this fix appears in an I-build, I would appreciate your colleague checking it out when it appears in the build.
(and sorry for misspelling your name so many times before!)

Comment 22 Susan McCourt 2011-04-21 11:44:45 EDT

This fix was released for I20110421-0100.
Giedrius, could your colleague please verify that all is well?

Comment 23 Susan McCourt 2011-04-21 11:46:21 EDT

*** Bug 311037 has been marked as a duplicate of this bug. ***

Comment 24 Susan McCourt 2011-05-02 13:56:07 EDT

Giedrius, could you have your colleague verify that the 3.7 M7 build is working as expected on vista?

Comment 25 Giedrius Noreikis 2011-05-02 17:17:58 EDT

(In reply to comment #24)
> Giedrius, could you have your colleague verify that the 3.7 M7 build is working
> as expected on vista?

Yes, it is working as expected. Sorry for the delay.
Good job, Susan.