Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 228179 - IndexManager - new getSourceElementParser(IScriptProject) method
Summary: IndexManager - new getSourceElementParser(IScriptProject) method
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: 0.95   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-22 06:25 EDT by Alex Panchenko CLA
Modified: 2010-06-11 07:14 EDT (History)
2 users (show)

See Also:

Attachments
patch (8.13 KB, patch)
2008-04-22 06:25 EDT, Alex Panchenko CLA 		alex.panchenko: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Panchenko CLA 2008-04-22 06:25:32 EDT 
All but one calls to the 
getSourceElementParser(IScriptProject,ISourceElementRequestor)
pass second parameter as null with comment "requestor will be set by indexer".
So it is better to introduce new method with one parameter - the code will be more readable.
Comment 1 Alex Panchenko CLA 2008-04-22 06:25:56 EDT 
Created attachment 96994 [details]
patch
Comment 2 Alex Panchenko CLA 2008-04-22 06:26:58 EDT 
Legal Message: I, Alex Panchenko, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer (xored software, Inc.) to make this contribution under the EPL.
Comment 3 Andrei Sobolev CLA 2008-04-24 00:19:46 EDT 
Applied.
Comment 4 Andrey Platov CLA 2008-05-26 02:48:36 EDT 
bulk change: fixed in 0.95