Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 228110 - [Markers] Problems view: Improve 'Warnings on Selection'
Summary: [Markers] Problems view: Improve 'Warnings on Selection'
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-21 17:19 EDT by Martin Aeschlimann CLA
Modified: 2009-06-03 13:16 EDT (History)
4 users (show)

See Also:

Attachments
Patch 1 (4.15 KB, patch)
2008-11-24 05:45 EST, Hitesh CLA 		Kevin_McGuire: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2008-04-21 17:19:10 EDT 
20080421

The problems view has a built-in configuration 'Warnings on Selection'.
I wonder how useful this is. Wouldn't it be more useful to change this to 'Error/Warnings on Selection'? That's something I often use.

Other useful configuration worthy to be built-in:
'Error/Warnings on Same Project'
Comment 1 Hitesh CLA 2008-11-24 05:45:38 EST 
Created attachment 118576 [details]
Patch 1
Comment 2 Kim Horne CLA 2008-11-28 12:47:13 EST 
Tod, do you think we should add these?
Comment 3 Tod Creasey CLA 2008-11-28 13:57:56 EST 
I am OK with adding something new but I know many people like to see all of thier errors (as it prevents them launching etc) but want to filter the warnings down to the selection.

Removing this would be a regression I think. Incidentally I use the all errors/ warnings on selection combination as my working mode.
Comment 4 Hitesh CLA 2009-01-16 02:40:50 EST 
The patch adds two new filters (no removals:-) ).Eric , this would be a nice addition to the set of existing filters.
Comment 5 Eric Moffatt CLA 2009-01-16 13:36:25 EST 
Hitesh, I'm a bit confused as to why adding a couple of new options requires the various 'areas' to implement a 'grabExcessVerticalSpace' method. Can you explain where the two areas are used so I can take a look at the effect?
Comment 6 Eric Moffatt CLA 2009-01-19 09:35:49 EST 
Hitesh just pinged me that he was confused about my 'I'm confused' comment. Understandable since my comment was based on code not associated with the patch (I must have had some stale code in the WS when I looked at the code in the Synch view...).

The patch is fine Hitesh. Committed in >20090119. Applied the patch.
Comment 7 Eric Moffatt CLA 2009-01-19 09:36:21 EST 
Setting milestone
Comment 8 Oleg Besedin CLA 2009-01-30 15:29:14 EST 
Verified in I20090129-0100.