Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 227803 - Add messages for compatible deltas
Summary: Add messages for compatible deltas
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-18 13:17 EDT by Olivier Thomann CLA
Modified: 2008-04-29 16:43 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2008-04-18 13:17:40 EDT 
We should add message for compatible deltas. Right now we only handle the breaking delta.
For example, when we report a delta for a method addition in an interface that is tagged with @noimplement, we use the message defined to report a method addition in an interface that is *not* tagged with @noimplement.

I think we should add the delta restriction when we build the key for the delta's message.
Comment 1 Olivier Thomann CLA 2008-04-29 02:30:23 EDT 
Released first draft.
Will review all existing messages for breaking changes tomorrow.
Comment 2 Olivier Thomann CLA 2008-04-29 13:38:55 EDT 
Released for 3.4M7.
Comment 3 Olivier Thomann CLA 2008-04-29 13:39:11 EDT 
Fixed.
Darin, please verify.
Comment 4 Darin Wright CLA 2008-04-29 16:43:34 EDT 
I looked through the message catalog and made a few minor changes. Also, debugged some compatible deltas to see the messages created (they don't appear anywehere in the UI).