Community
Participate
Working Groups
Build ID: Eclipse 3.4 M6 Steps To Reproduce: try to access a remote information center that is configured with secure HTTP. More information: When building the remote assistance url, we have hard coded the HTTP protocol. If the site is secure (and there are several reasons to secure a remote IC). Additional information: I'm not sure we can get this done for V3.4. We would also need to surface the property (secure http) to the preferences ui.
Changing from a defect to an enhancement.
I don't think we have time to do this for Eclipse 3.4.
Created attachment 157868 [details] Patch for HTTPS support There may be some doc impact but the code patch is here. Tested HTTPS scenarios and verified JUnits still pass Patch includes patch for: org.eclipse.help.base org.eclipse.help.ui org.eclipse.ua.tests
Can you create the doc patch also? The page that needs to change is /org.eclipse.platform.doc.isv/guide/ua_help_setup_preferences.htm.
Created attachment 158192 [details] Patch including doc patch This patch includes all of the fixed in the previous patch as well as the doc fix.
I'm almost ready to commit the files, can you first make sure all of the source files have a 2010 copyright. In the documentation page you should indicate that if no protocol is specified http will be used. Also in the doc page you need to change "The 5 remote help preferences below" to "The 6 remote help preferences below" . Once I have those changes I can commit everything.
Created attachment 158235 [details] Patch for HTTPS support including doc patch, 2010 copyrights, support for no protocol specified This patch contains all of the fixes in the previous patches, and also fixes for: - 2010 Copyright in all changed files - Doc fixes for no protocol specificed and 6 remote preferences - Support for using http if no protocol specified
Patch committed to HEAD, Fixed
Can someone explain why you need to set the system property: System.setProperty( "java.protocol.handler.pkgs" , "javax.net.ssl" ); At a minimum I think you need to check for an existing "java.protocol.handler.pkgs" property and append "|javax.net.ssl" if it already exists.
Setting java.protocol.handler.pkgs=javax.net.ssl implies that we expect the class javax.net.ssl.https.Handler to exist for handling https protocols. What version of java does this exist?
Removing the line: System.setProperty( "java.protocol.handler.pkgs" , "javax.net.ssl" ); Causes remote help to still work (on Windows). So at minimum, the line may not be required. I will investigate Linux and Solaris to verify that the handler package is supported there as well.
I've opened Bug 329280 to track the java.protocol.handler.pkgs issue. We can move the discussion there.
