Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 226738 - [terminal] Terminal Unit Tests Fail
Summary: [terminal] Terminal Unit Tests Fail
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 168197
  Show dependency tree
 
Reported: 2008-04-11 14:22 EDT by Martin Oberhuber CLA
Modified: 2008-04-11 15:27 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-04-11 14:22:20 EDT 
Following Terminal Unit Tests fail in HEAD (3.0M6 candidate):
  testIsInitialized
  testGetAdapter
Please investigate urgently

-----------Enter bugs above this line-----------
TM 3.0M6 testing
installation : eclipse-SDK-3.4M6 (I20080330-1350), cdt-4.0.0M5, emf-2.4.0M5
     DSF-N20071113, ECF-2.0m5, PHPEclipse-1.2.0.20080208, Releng.Tools-3.4M5,
     Subversive-0.7.0.v20080214, SWT-MemMonitor, WR-Retriever-3.0.v20070604,
     Mylyn-2.3.0.I20080214-1500, RXTX-2.1-7r3b, J9Launching
RSE install  : RSE HEAD 3.0M6 candidate in workspace, TM-terminal, TM-discovery
java.runtime : Sun 1.4.2_17
os.name:     : Windows XP 5.1, Service Pack 2
------------------------------------------------
systemtype   : Windows-local, Dstore-win, Dstore-linux
targetos     : Red Hat Enterprise Linux WS release 4 (Nahant Update 3)
targetuname  : Linux parser 2.6.9-34.EL #1 i686 athlon i386 GNU/Linux
targetvm     : Sun Java HotSpot(TM) Client VM (build 1.4.2_12-b03, mixed mode)
------------------------------------------------
Comment 1 Martin Oberhuber CLA 2008-04-11 15:10:24 EDT 
The problem with these tests is that they need the Platform's IAdapterManager to work. The Adapter Manager works only if running inside an OSGi Runtime, so the test would need to run as a "JUnit Plug-in Test".

But the Terminal Tests are currently all standard JUnit tests.
Comment 2 Martin Oberhuber CLA 2008-04-11 15:27:03 EDT 
I crated team-shared Launches for two variants of Terminal Tests:
  - Terminal Plug-in Tests
  - Terminal All Unit Tests

For a test to run as Plug-in Test, it needs to be referenced from the new "AutomatedPluginTests" test suite holder class. Tests that don't run as JUnit need to be qualified with an 
   if (!Platform.isRunning()) return;
in the beginning, and added to a separate test class that can be referenced from the AutomatedPluginTests class.

[226738] Create team-shared Launches for Terminal Tests