226598 – move "Validate Settings" button to the lower-left of the dialog

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 226598 - move "Validate Settings" button to the lower-left of the dialog

Summary: move "Validate Settings" button to the lower-left of the dialog

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	PC Windows Vista

Importance:	P3 enhancement (vote)
Target Milestone:	3.1
Assignee:	Helen Bershadskaya
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-04-10 16:37 EDT by Mik Kersten
Modified:	2009-02-19 13:31 EST (History)
CC List:	2 users (show)

See Also:

Attachments
patch for moving validate settings button to bottom of repository settings wizard (8.72 KB, patch) 2009-01-15 03:16 EST, Helen Bershadskaya	no flags	Details \| Diff
mylyn/context/zip (41.53 KB, application/octet-stream) 2009-01-15 03:17 EST, Helen Bershadskaya	no flags	Details
screenshot (29.50 KB, image/png) 2009-01-15 19:17 EST, Steffen Pingel	no flags	Details
fix for missing button on new repository dialog (4.81 KB, patch) 2009-01-30 20:27 EST, Helen Bershadskaya	no flags	Details \| Diff
mylyn/context/zip (26.29 KB, application/octet-stream) 2009-01-30 20:27 EST, Helen Bershadskaya	no flags	Details
Patch ensuring validate button is disabled on validate action (16.87 KB, patch) 2009-02-18 03:04 EST, Helen Bershadskaya	no flags	Details \| Diff
mylyn/context/zip (47.21 KB, application/octet-stream) 2009-02-18 03:04 EST, Helen Bershadskaya	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mik Kersten

2008-04-10 16:37:54 EDT

This should make it more prominent and make it look like it's an action over all of the settings instead of something embedded in the page.  A concern I have is whether some users would think that this action would close the dialog.  However, in search the "Customize..." left aligned action does not close the dialog, and neither does the little question mark.  So we should be OK with this approach.

Comment 1 Mik Kersten

2008-06-12 22:56:06 EDT

I would like to do this for 3.0.1 because I think it would make it easier for people to notice that button.

Comment 2 Mik Kersten

2008-06-24 17:51:46 EDT

Steffen: should we hold off UI changes of this sort until 3.0.1?  We can make this a part of general improvements of the repository properties dialog. 

For an example of how to do this see the "New Task..." button in the "Open Task" dialog.

Comment 3 Steffen Pingel

2008-10-07 00:06:23 EDT

Helen, assigning to you. This is related to the other changes planned for the repository settings dialog.

Comment 4 Helen Bershadskaya

2009-01-15 03:16:56 EST

Created attachment 122638 [details]
patch for moving validate settings button to bottom of repository settings wizard

I couldn't come up with a good way to test these UI changes, but let me know if you think this is still required.

Comment 5 Helen Bershadskaya

2009-01-15 03:17:00 EST

Created attachment 122639 [details]
mylyn/context/zip

Comment 6 Steffen Pingel

2009-01-15 19:17:35 EST

Created attachment 122762 [details]
screenshot

Comment 7 Steffen Pingel

2009-01-15 19:21:45 EST

The patch looks great. I am unsure if we should make AbstractRepositorySettingsPage.validateSettings() public in stead of making RepositorySettingsWizardDialog an API class since clients are expected to use TasksUiUtil to open a properties page.

Mik, can you review the screenshot?

Comment 8 Mik Kersten

2009-01-27 20:37:28 EST

Looks good!

Comment 9 Steffen Pingel

2009-01-29 18:58:11 EST

I have applied the patch. Great work Helen!

Comment 10 Steffen Pingel

2009-01-30 18:46:38 EST

David pointed out that the validate button is now missing when creating new repositories. Helen, could you add the button to the new repository wizard as well?

Comment 11 Helen Bershadskaya

2009-01-30 20:27:41 EST

Created attachment 124348 [details]
fix for missing button on new repository dialog

Comment 12 Helen Bershadskaya

2009-01-30 20:27:47 EST

Created attachment 124349 [details]
mylyn/context/zip

Comment 13 Steffen Pingel

2009-02-02 00:40:21 EST

Excellent! I have simplified the patch slightly to always create the validate button since it's only shown if a page requests validation.

Comment 14 Steffen Pingel

2009-02-16 21:26:21 EST

The validate settings button is not disabled while validation is in progress: Pressing the button twice causes an error.

Comment 15 Helen Bershadskaya

2009-02-18 03:04:04 EST

Created attachment 125996 [details]
Patch ensuring validate button is disabled on validate action

Had to add code to the wizard dialog to allow this to happen

Comment 16 Helen Bershadskaya

2009-02-18 03:04:09 EST

Created attachment 125997 [details]
mylyn/context/zip

Comment 17 Steffen Pingel

2009-02-19 13:31:08 EST

Thanks Helen! I have committed the fix.