Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 226583 - Servlet creation wizard is not Project context sensitive
Summary: Servlet creation wizard is not Project context sensitive
Status: CLOSED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.servlet (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 blocker (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Dimitar Giormov CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on: 226527
Blocks: 226933
  Show dependency tree
 
Reported: 2008-04-10 15:12 EDT by Neeraj Agrawal CLA
Modified: 2008-05-19 07:37 EDT (History)
1 user (show)

See Also:
cbridgha: review+

Attachments
patch for the servlet, filter, listener project selection (8.03 KB, patch)
2008-04-14 07:21 EDT, Dimitar Giormov CLA 		no flags Details | Diff
fixes cycle dependency (2.61 KB, patch)
2008-04-16 02:20 EDT, Dimitar Giormov CLA 		dimitar.giormov: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neeraj Agrawal CLA 2008-04-10 15:12:12 EDT 
Build ID: Eclipse 3.4

Steps To Reproduce:
1.Create couple of Web projects 

2.Launch Servlet creation wizard by right click on the Deployment desctiptor node of the last web project

3. The project chosen in the wizard is the first one

The wizard should set the project as the default one on which it is invoked.

More information:
Comment 1 Kaloyan Raev CLA 2008-04-14 05:33:01 EDT 
This bug is valid only in the case of Web 2.5 projects.
Comment 2 Dimitar Giormov CLA 2008-04-14 07:21:53 EDT 
Created attachment 95898 [details]
patch for the servlet, filter, listener project selection

the patch fixes context project selection in 5.0 wizards.
The patch also fixes context project selection, when selected node is Servlets, Filters or Listeners, but will work, when the 226527 bug is committed.
Comment 3 Dimitar Giormov CLA 2008-04-14 07:22:40 EDT 
Chuck can you review the patch.
Comment 4 Chuck Bridgham CLA 2008-04-15 10:49:31 EDT 
Approved
Comment 5 Kaloyan Raev CLA 2008-04-15 13:35:50 EDT 
dropped to HEAD
Comment 6 Chuck Bridgham CLA 2008-04-15 18:14:08 EDT 
Ok - sorry didn't review very closely....

Circular dependency introduced....
Comment 7 Dimitar Giormov CLA 2008-04-16 02:20:34 EDT 
Created attachment 96192 [details]
fixes cycle dependency

Sory about that. I checked for dependencies and fixed it, but I should have checked again.

The patch will fix the cycle dependency. I may be wrong, but from my point of view there is something wrong with the plugin structure, from architectural point of view the "org.eclipse.jst.j2ee.navigator.ui" should be base for "org.eclipse.jst.j2ee.servlet.ui" and "org.eclipse.jst.jee.ui", and should not refer either of them, I think similar problem is with ejb.ui. 

Chuck is there a plugin dependency graph for WTP?
Comment 8 Kaloyan Raev CLA 2008-04-16 03:00:14 EDT 
I hurry up to drop and release the patch, so we have the build fixed as soon as possible. 

Chuck, please still have a review to see if there is something wrong introduced by the second patch.
Comment 9 Chuck Bridgham CLA 2008-04-16 08:48:45 EDT 
Actually, "org.eclipse.jst.j2ee.navigator.ui" was traditionally where we put the content providers for all the legacy models, and had dependencies to all the bundles, and we should consider either creating a new bundle for the jee navigator content "org.eclipse.jst.jee.navigator.ui" or possibly add them to the existing navigator bundle.

I know Konstantin had a good plugin graph at the start of R3 - will need to search

Patch looks good
Comment 10 Kaloyan Raev CLA 2008-04-18 04:28:58 EDT 
Verified with the I20080417213732 build.
Comment 11 Kaloyan Raev CLA 2008-05-19 07:37:23 EDT 
Closing