Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 226576 - [sec] messages params are reversed for missing files in a signed jar
Summary: [sec] messages params are reversed for missing files in a signed jar
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-10 14:14 EDT by Thomas Watson CLA
Modified: 2008-04-10 14:34 EDT (History)
0 users

See Also:

Attachments
patch (3.31 KB, patch)
2008-04-10 14:33 EDT, Thomas Watson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2008-04-10 14:14:59 EDT 
See bug 226420.  The error message that occurs when a missing file is detected in a signed bundle has the jar path and the resource path reversed.  This results in the following message:

java.lang.SecurityException: A file
"C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\signatureFile42527.jar" has been removed
from the jar: css/ng400.gif
        at
org.eclipse.osgi.internal.signedcontent.SignedBundleFile.getEntry(SignedBundleFile.java:110)
        at
org.eclipse.osgi.internal.signedcontent.SignedContentImpl$SignedContentEntryImpl.verify(SignedContentImpl.java:158)
Comment 1 Thomas Watson CLA 2008-04-10 14:16:36 EDT 
Also we should probably not be throwing a security exception here.
Comment 2 Thomas Watson CLA 2008-04-10 14:33:22 EDT 
Created attachment 95576 [details]
patch

Fixes the error message and fixes the SecurityException to throw an InvalidContentException.
Comment 3 Thomas Watson CLA 2008-04-10 14:34:30 EDT 
Fixed for M7.