Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 226527 - NPE in content providers
Summary: NPE in content providers
Status: CLOSED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Dimitar Giormov CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 226583 226933
  Show dependency tree
 
Reported: 2008-04-10 10:28 EDT by Dimitar Giormov CLA
Modified: 2008-05-19 07:38 EDT (History)
1 user (show)

See Also:
cbridgha: review+

Attachments
fixes the NPE + some refactoring (46.82 KB, patch)
2008-04-14 04:14 EDT, Dimitar Giormov CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitar Giormov CLA 2008-04-10 10:28:02 EDT 
Build ID: I20080330-1350

Steps To Reproduce:
NPE occures in Java EE 5 content providers
Could not acquire children from extension: org.eclipse.jst.jee.ui.web
java.lang.NullPointerException
	at org.eclipse.jst.j2ee.navigator.internal.J2EEContentProvider.getParent(J2EEContentProvider.java:134)
	at org.eclipse.ui.internal.navigator.extensions.SafeDelegateTreeContentProvider.getParent(SafeDelegateTreeContentProvider.java:103)
	at org.eclipse.ui.internal.navigator.NavigatorContentServiceContentProvider.getParent(NavigatorContentServiceContentProvider.java:480)
	at org.eclipse.jface.viewers.AbstractTreeViewer.getParentElement(AbstractTreeViewer.java:1646)
	at org.eclipse.jface.viewers.TreeViewer.getParentElement(TreeViewer.java:595)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalExpand(AbstractTreeViewer.java:1573)



and 


Could not acquire children from extension: org.eclipse.jst.jee.ui.web
java.lang.NullPointerException
	at org.eclipse.jst.j2ee.navigator.internal.J2EEContentProvider.getParent(J2EEContentProvider.java:134)
	at org.eclipse.ui.internal.navigator.extensions.SafeDelegateTreeContentProvider.getParent(SafeDelegateTreeContentProvider.java:103)
	at org.eclipse.ui.internal.navigator.NavigatorContentServiceContentProvider.findParents(NavigatorContentServiceContentProvider.java:858)
	at org.eclipse.ui.internal.navigator.NavigatorContentServiceContentProvider.findPaths(NavigatorContentServiceContentProvider.java:797)
	at org.eclipse.ui.internal.navigator.NavigatorContentServiceContentProvider.getParents(NavigatorContentServiceContentProvider.java:679)
Comment 1 Dimitar Giormov CLA 2008-04-14 04:14:36 EDT 
Created attachment 95875 [details]
fixes the NPE + some refactoring

fixes the NPE, 
some refactoring of content providers, 
several issues with non existing classes described in xml (NPEs)
Added resource property to the merged model.
Open on Ejb Deployment descriptor now works.
Open of Ejb interfaces is fixed.
Comment 2 Dimitar Giormov CLA 2008-04-14 06:29:42 EDT 
Hi Chuck,
please review the fix.
Comment 3 Chuck Bridgham CLA 2008-04-15 10:42:23 EDT 
Changes looks good - make sure fluffing up an Empty Resource class doesn't cause regressions though
Comment 4 Kaloyan Raev CLA 2008-04-15 13:23:34 EDT 
dropped to HEAD
Comment 5 Kaloyan Raev CLA 2008-04-18 04:30:47 EDT 
Verified with the I20080417213732 build. 

The NPE did not appear during smoke testing.
Comment 6 Kaloyan Raev CLA 2008-05-19 07:38:28 EDT 
Closing