Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 226417 - ASCIZ string support in BCI
Summary: ASCIZ string support in BCI
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Asaf Yaffe CLA
QA Contact:
URL:
Whiteboard: closed460
Keywords:
Depends on:
Blocks: 148629
  Show dependency tree
 
Reported: 2008-04-09 23:48 EDT by Vasily v. Levchenko CLA
Modified: 2016-05-05 10:47 EDT (History)
4 users (show)

See Also:
asaf.yaffe: review+

Attachments
patch introduces allocation +1 byte to m_pu1Bytes and injection end of line symbol (713 bytes, patch)
2008-04-09 23:48 EDT, Vasily v. Levchenko CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vasily v. Levchenko CLA 2008-04-09 23:48:42 EDT 
Created attachment 95469 [details]
patch introduces allocation +1 byte to m_pu1Bytes and injection end of line symbol 

External components (e.g. verifier for stack map recalculations) involving in class file processing rely on ASCIZ nature UTF8 entries of Constant Pool.  

In attached patch additional space reserving for end of line symbol '\0' and injection of it at the end of string, that make possible using string functions and don't break functionality relying on CCPUtf8Info::GetLength()
Comment 1 Alexander N. Alexeev CLA 2008-04-10 05:52:07 EDT 
Asaf, could your review the patch and commit if everything is Ok?
Comment 2 Asaf Yaffe CLA 2008-04-10 06:13:34 EDT 
Patch is OK.
Comment 3 Asaf Yaffe CLA 2008-04-10 07:06:29 EDT 
This bug fix is included in the BCI engine cumulative update for supporting Java 6. Therefore, it should be checked-in as part of this cumulative update.
Comment 4 Asaf Yaffe CLA 2008-04-13 06:20:57 EDT 
In plan for 4.5.i7, pending check-in of Java 6 support (bug 148629)
Comment 5 jkubasta CLA 2008-06-05 18:19:44 EDT 
Went to apply patch to Head with PMC approval but patch appears to have already been checked in. Please confirm.
Comment 6 jkubasta CLA 2008-06-05 18:32:11 EDT 
Appears to have been checked in under patch for 148629
Comment 7 Paul Slauenwhite CLA 2009-06-30 13:21:15 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.