Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 226191 - Multiple CVS problems - cannot tag project, cannot commit
Summary: Multiple CVS problems - cannot tag project, cannot commit
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: CVS (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 228129
  Show dependency tree
 
Reported: 2008-04-08 15:50 EDT by Boris Bokowski CLA
Modified: 2008-04-22 17:22 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2008-04-08 15:50:17 EDT
I cannot tag a project in CVS. This is preventing us from getting a good integration build. It would be great if you could look at this as soon as possible:

  The server reported an error while performing the "cvs tag" command.
  org.eclipse.jface.tests.databinding: cvs [tag aborted]: could not open lock file `/cvsroot/eclipse/org.eclipse.jface.tests.databinding/,.classpath,': Permission denied

I don't have shell access to dev.eclipse.org anymore (even though I asked <g>), so I cannot give you more specific information.

My account name is "bbokowski".
Comment 1 Denis Roy CLA 2008-04-08 16:09:11 EDT
Looks like you're not in plat-ui-bindings.  Please have your PMC +1 your addition to that group.
Comment 2 Denis Roy CLA 2008-04-08 16:18:10 EDT
(In reply to comment #1)
> Looks like you're not in plat-ui-bindings.  Please have your PMC +1 your
> addition to that group.
> 

Cancel that.  You're in plat-ui and there's an ACL on the dir for plat-ui.  We'll investigate.
Comment 3 Boris Bokowski CLA 2008-04-09 16:04:35 EDT
(In reply to comment #2)
> We'll investigate.

How is the investigation going? I got another CVS error just now:
Problems encountered performing commit
  The server reported an error while performing the "cvs commit" command.
  org.eclipse.jface.databinding: cvs [commit aborted]: could not open lock file `/cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/viewers/,ObservableListContentProvider.java,': Permission denied

Comment 4 Denis Roy CLA 2008-04-09 16:24:24 EDT
We have concluded that although plat-ui is listed as an ACL, the ACL is not being respected.  This has started occurring since I moved CVS to a different disk array some time ago.

At any rate, the easy way out now would be to execute my suggestion in comment 1.  We don't have any immediate leads as to why ACLs are not working.
Comment 5 Boris Bokowski CLA 2008-04-09 16:29:29 EDT
Wouldn't that require more than just adding me to a group? Sounds like this would only fix the problem for me, but not for others who are listed in the ACL but not in plat-ui-bindings. E.g. Sonia or Kim...
Comment 6 Denis Roy CLA 2008-04-09 16:48:30 EDT
I said the easy way out 'now'. We've already drawn the conclusion that we have a bigger issue on our hands than only your commit rights, but we can't fix problems when we don't know the cause....
Comment 7 Boris Bokowski CLA 2008-04-10 11:39:33 EDT
Mcq, can you please +1 my addition to the plat-ui-bindings group?
Comment 8 Mike Wilson CLA 2008-04-10 18:08:14 EDT
+1
Comment 9 Eclipse Webmaster CLA 2008-04-10 18:39:22 EDT
I've added you to plat-ui-bindings.

-M.
Comment 10 Boris Bokowski CLA 2008-04-22 00:39:39 EDT
This problem has hit me again. This time, I was not able to commit a change to the project /cvsroot/eclipse/org.eclipse.ui.tests.navigator.

The result of this is going to be a broken integration build tomorrow morning unless I can find someone who gets up very early and is not affected in the same way.

I am quite sure that the cause is the same, but I cannot check that because I cannot ssh into dev.eclipse.org anymore. (This was possible just after I filed this bug - have you removed my login privileges again?)

Upping the severity. I have heard from John that he was not able to commit to certain projects in CVS as well.

Can you please either
1. find the root cause and fix it or
2. add people to more groups so that ACLs are no longer needed, now that the 16 groups limit has been lifted.

Thanks!
Comment 11 Denis Roy CLA 2008-04-22 08:26:19 EDT
I'll look into this to see what I can do.
Comment 12 Denis Roy CLA 2008-04-22 09:08:53 EDT
Agh.  Karl, Matt, the kernel patch we're using to bypass the 16 group limit causes issues for *group*-based ACLs.  

    http://www.frankvm.com/nfs-ngroups/README (see the TODO)

When I tested the patch, I tested ACLs with Kim Moir's account, and she (and Sonia) have a user-based ACL, which work.

From here, understanding the standardized groups effort will require the >16 patch, I'll go ahead and "undo" the need for group-based ACLs on CVS, and I'll add committers to the appropriate groups.
Comment 13 Denis Roy CLA 2008-04-22 10:02:12 EDT
I undid all the eclipse project ACLs where multiple groups were assigned to the same directories, by adding members of plat-ui to the smaller subset or by creating new groups.  This is what would (and will) have happened under the standardized groups anyway.

You should be all set.  There may be corner cases left, but I merged all the ACLs that were documented.  

Karl, Matt, I've kept the ACLs on the FS anyway, as we're not running a patched kernel on build.
Comment 14 Denis Roy CLA 2008-04-22 10:02:37 EDT
Closing as fixed.
Comment 15 Denis Roy CLA 2008-04-22 16:15:53 EDT
Boris -- I'm dying to know ... Has this fixed your problem?  Are you able to get things done?
Comment 16 Boris Bokowski CLA 2008-04-22 17:22:44 EDT
Yes - all is fine now.  Thanks for fixing it!