Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 226085 - Open JavaScript Type icon shouldn't appear in all perspectives
Summary: Open JavaScript Type icon shouldn't appear in all perspectives
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Phil Berkland CLA
QA Contact: Phil Berkland CLA
URL:
Whiteboard:
Keywords:
: 227216 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-04-08 03:56 EDT by Litrik De Roy CLA
Modified: 2010-03-03 11:15 EST (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Litrik De Roy CLA 2008-04-08 03:56:32 EDT
Build ID: 3.4M6 I20080330-1350 with wtp-wst-S-3.0M6-20080404175400.zip

See bug 208711 where the same thing happened with the web browser icon. See bug 109402 for why this is bad.
Comment 1 Kim Horne CLA 2008-04-17 17:16:57 EDT
+1
Comment 2 Boris Bokowski CLA 2008-04-17 23:53:42 EDT
+1
Comment 3 Willian Mitsuda CLA 2008-04-18 02:45:35 EDT
*** Bug 227216 has been marked as a duplicate of this bug. ***
Comment 4 Willian Mitsuda CLA 2008-04-18 02:47:46 EDT
Note that in addition to appearing in the toolbar, this command is also appearing in navigate menu in all perspectives.
Comment 5 Erkki Lindpere CLA 2008-04-18 08:37:25 EDT
+2
Comment 6 Nitin Dahyabhai CLA 2008-04-18 12:52:48 EDT
Phil, is it possible to clear this up?  I know there might be issues with ensuring that there's at least one perspective where it's properly available by default depending on the configuration.
Comment 7 Andreas Goetz CLA 2008-04-18 13:51:42 EDT
+1
Comment 8 Bradley Childs CLA 2008-04-18 16:25:18 EDT
fixed: (visible from true->false in plugin.xml)
   <extension
         point="org.eclipse.ui.actionSets">
      <actionSet
            label="%JavaActionSet.label"
            description="%JavaActionSet.description"
            visible="false"
            id="org.eclipse.wst.jsdt.ui.JavaActionSet2">
         <action
               id="openType"
               toolbarPath="org.eclipse.search.searchActionSet/Search"
               class="org.eclipse.wst.jsdt.internal.ui.actions.OpenTypeAction"
               definitionId="org.eclipse.wst.jsdt.ui.navigate.open.type"
               icon="$nl$/icons/full/etool16/opentype.gif"
               helpContextId="org.eclipse.wst.jsdt.ui.open_type_action"
               label="%OpenTypeAction.label"
               menubarPath="navigate/open.ext2"
               tooltip="%OpenTypeAction.tooltip">
         </action>
      </actionSet>
   </extension>

javascript perspective will still show open type.
Comment 9 Litrik De Roy CLA 2008-04-18 16:51:49 EDT
Thanks for the fix. Looking forward to M7 to test it.