Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 225647 - Enhanced Java Content for Web navigator content priority probably too high
Summary: Enhanced Java Content for Web navigator content priority probably too high
Status: RESOLVED WONTFIX
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows Vista
: P3 minor (vote)
Target Milestone: 4.0   Edit
Assignee: Dimitar Giormov CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on: 228022
Blocks:
  Show dependency tree
 
Reported: 2008-04-03 16:43 EDT by Paul Fullbright CLA
Modified: 2011-06-13 13:07 EDT (History)
2 users (show)

See Also:
cbridgha: review+


Attachments
severity is reduced to high. (853 bytes, patch)
2008-04-18 04:13 EDT, Dimitar Giormov CLA
dimitar.giormov: review?
Details | Diff
Before screenshot (6.81 KB, image/jpeg)
2008-04-18 04:14 EDT, Dimitar Giormov CLA
no flags Details
After severity change. (6.47 KB, image/jpeg)
2008-04-18 04:14 EDT, Dimitar Giormov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Fullbright CLA 2008-04-03 16:43:56 EDT
Right now the navigator content priority for this contribution is "higher", which makes it hard for us (JPA) to place our content, which we feel should be lower than core module content (EJB, Web deployment descriptors, etc.) but higher than resources and (probably) also this content.  If we set our content priority to be "higher", it keeps us lower than core module content, but also consistently lower than enhanced java content for the web.  If we set our priority to be "highest", it puts us higher than core module content at times.  Java content (jdt) by itself is at priority "high", which I think should be appropriate for this content, because it seems to replace that content.  Are there reasons for setting this priority higher?
Comment 1 Kaloyan Raev CLA 2008-04-04 03:23:48 EDT
Dimitar, please take care of this.

Paul, I hope this is not urgent and M7 is a good target for the fix?
Comment 2 Paul Fullbright CLA 2008-04-04 10:26:15 EDT
No, that's absolutely soon enough.  This is a minor change and will allow us to respond soon enough.

Thanks.
Comment 3 Dimitar Giormov CLA 2008-04-18 04:13:37 EDT
Created attachment 96562 [details]
severity is reduced to high.

here is a fix, but unfortunately it brings some implications, the build folder is placed right after Deployment Descriptor and in this way the web project becomes the only one that looks in this way. See before and after screenshots.

Here again I ran into the Common Navigator framework and I was not able to move the build folder to the bottom as it is in all other project.

@Chuck: please see the screenshots. I am not really confident in this fix.
Comment 4 Dimitar Giormov CLA 2008-04-18 04:14:20 EDT
Created attachment 96564 [details]
Before screenshot
Comment 5 Dimitar Giormov CLA 2008-04-18 04:14:48 EDT
Created attachment 96565 [details]
After severity change.
Comment 6 Chuck Bridgham CLA 2008-04-18 08:29:58 EDT
I'm ok with this, but JDT UI contribution should not be "high".   We really need to get them to reduce it to "normal" at least so we have more options.
Comment 7 Dimitar Giormov CLA 2008-04-21 10:42:45 EDT
bug in JDT created. 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=228022
Comment 8 Kaloyan Raev CLA 2008-04-24 15:25:29 EDT
We want to hold on applying the patch until bug 228022 is clarified. 
Moving to RC1. 
Comment 9 Boris Bokowski CLA 2008-05-14 21:43:45 EDT
Paul/Dimitar/Chuck/Kaloyan: Why is this bug marked as minor, but at the same time you are pushing on Platform UI to fix bug 228022 for 3.4 after our API freeze?
Comment 10 Kaloyan Raev CLA 2008-05-15 05:29:26 EDT
(In reply to comment #9)
> Paul/Dimitar/Chuck/Kaloyan: Why is this bug marked as minor, but at the same
> time you are pushing on Platform UI to fix bug 228022 for 3.4 after our API
> freeze?
> 

See my comment in bug 228022:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=228022#c25
Comment 11 Kaloyan Raev CLA 2008-05-15 14:14:08 EDT
Bug 228022 has been re-targeted to Eclipse SDK 3.5. So, I guess we have to re-target this one for WTP 4.0. 
Comment 12 Dimitar Giormov CLA 2009-04-13 06:04:16 EDT
Hi Paul,

the fix in the platform should solve your problem and does not require a fix for us. If this works for you please close the bug entry.
Comment 13 Paul Fullbright CLA 2009-04-13 11:32:58 EDT
I'm not sure how the fix in platform resolves this issue for us.  Seems they implemented something for *action providers* but I don't see what they did for navigator content.  Our JPA content still falls below the web "build" folder for some reason, even at priority "higher".
Comment 14 Dimitar Giormov CLA 2010-05-31 09:49:58 EDT
From the platform team there is a new option available, which should enable you to achieve the ordering you like.

The new property is "appearsBefore" option in the content provider and it allows control over the ordering of the content providers.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=228022#c46

Can you confirm that this is enough for you?
Comment 15 Paul Fullbright CLA 2010-11-29 11:59:56 EST
Finally made it onto my plate to check this out.  This does work to allow us to place ourselves in the tree properly.

But now I ask - why is JAX-WS using "highest"?  Shouldn't that also be using "higher" and "appearsBefore" to correctly place it?
Comment 16 Dimitar Giormov CLA 2011-01-27 04:12:21 EST
Hi Paul,

I will close this bug report. You can open a separate bug for the JAX-WS.

Is this ok with you?
Comment 17 Paul Fullbright CLA 2011-01-27 17:37:20 EST
Sure.
Comment 18 Dimitar Giormov CLA 2011-01-28 05:10:26 EST
228022 enables more refined positioning of the nodes.
Comment 19 Paul Fullbright CLA 2011-06-13 12:47:06 EDT
We have a problem with this behavior.  It appears that "appearsBefore" causes a problem if the referenced content provider is not in the workspace.

(see bug 349108)

We do not want to depend on the plugin declaring that content type.  I would prefer that the reference to that content provider would not *require* that dependency.

Should this be logged in a separate bug?
Comment 20 Paul Fullbright CLA 2011-06-13 13:07:53 EDT
Sorry, meant to put this on the parent bug.