Community
Participate
Working Groups
Usage of ProxyAuthentication with JPA needs to be simplified. 1. The Proxy properties should be passed in through the EMF.createEntityManager 2. The connection should be proxied and held as an exclusive connection for the life-cycle of the EntityManager. The EM being closed or GC'd should cause the connection's proxy session to be closed and returned to the data source. May require changes to have the EntitymanagerImpl hold onto its ClientSession. 3. Configuration of ProxyAuthentication needs to be made clear and well documented with examples.
Created attachment 97508 [details] The first take on Proxy Authentication patch The patch implements my posting at http://wiki.eclipse.org/EclipseLink/Development/Oracle/ProxyAuthentication Not tested yet.
I found problems with the Proxy Authentication patch: the only case that currently works is ServerSession using External connection pool. Refactoring the patch.
Created attachment 97680 [details] Proxy Authentication Patch - take 2 Fixed the problems of the first patch. Should work with both DatabaseSession and ServerSession (and ClientSessions), both external and internal pools. Still not tested.
Created attachment 98078 [details] Proxy Authentication Patch - take 3 Fix in DatasourceAccessor.createCustomizer method.
Created attachment 99143 [details] Proxy Authentication patch - take 4. This patch was tested and works (core tests only, no JPA tests yet). It contains a new ProxyAuthenticationCustomizerTestModel (under OracleTestModel in the TestingBrowser). The model requires the same proxy user setup as the old ProxyAuthenticationTestModel. No exceptions defined yet and "proxytype" is a current property name for specifying proxy type (such as OracleConnection.PROXYTYPE_USER_NAME).
Created attachment 99386 [details] Proxy Authentication patch - take 5. Some fixes, improved core tests.
If you'd like to test the patch make sure to use Oracle jdbc 10.1.0.2 or later. All you need to do is to pass proxy properties (including proxytype) to either createEMFactory or createEM method, for example: "proxytype" -> OracleConnection.PROXYTYPE_USER_NAME; OracleConnection.PROXY_USER_NAME -> "MyProxyUser"
Created attachment 102452 [details] The latest patch for proxy authentication (take 6). The latest fix for proxy authentication, includes both core and jpa tests. Provides support for Oracle PA using openProxySession (both JPA and core) in all cases (including ExclusiveIsolatedClientSession). Adds JPA property for specifying ExclusiveIsolatedClientSession (at least one descriptor must be isolated); Cleans up PropertiesHandler; EntityManagerProperties reuses names defined in PersistenceUnitPrioperties; Modifies uow to allow to instantiate ValueHolder when dead; Uow always released when em.close called (unless there's active trans - then it released when transaction is completed); RepeatbleWriteUow.release method releases change sets but not the cache. Usage of ExclusiveIsolatedClientSession should not cause connection leakage (provided that in JTA case the session is released by the user (core case) or em is closed (jpa case); Modified ExclusiveIsolatedClientSession not to through exception in case it instatiates ValueHolder for Isolated class while already been released - instead the new connection will be acquired and kept just for the duration of the query; Modified emSetupImpl so that listener passed to createEMF is actually used; Partially fixed partially worked around "java.lang.OutOfMemoryError: PermGen space" error that shows up in case of open/close the same factory many times, see the big comment in EntityManagerSetupImpl.predeploy method.
Also the patch removes the old code that supported openProxySession - based ProxyAuthentication, but the old code for OCI-based PA is kept (it's not covered by the new code). Tests: core: OracleModel -> ProxyAuthenticationCustomizerTestModel jpa: FullRegressionTestSuite -> ProxyAuthenticationTestSuite
Created attachment 102519 [details] Checked in patch for proxy authentication (take 7) This patch was just checked in. It has some minor fixes compared to the prev. one (uncomment some working code in a test, and remove the obsolete Connector).
Fixed.
Created attachment 102744 [details] Additional small patch to be applied on top of the previous one. This small patch based on feedback from James and Edwin: 1) Cleaned up some comments in PersistenceUnitProperties and EntityManagerProperties; 2) Moved Oracle-specific JPA tests from FullRegressionTestSuite to the newly created OracleJPATeatSuite. It should be applied on top of the previous patch.
Created attachment 102956 [details] Additional small testing patch to be applied on top of previous ones.
Created attachment 103163 [details] Additional small patch to be applied on top of the previous ones. Checked in a small patch that follows James's suggestion to move create/removeCustomizer into connect/disconnect of DatasourceAccessor.
Created attachment 103447 [details] This patch removes CONNECTION_ECLUSIVE property definition and support. Pending review CONNECTION_EXCLUSIVE property definition and support was removed. The issue will be resolved in a new bug 235433: Can't customize ConnectionPolicy through JPA.
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink
