This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 224775 - Handler conflict message in log
Summary: Handler conflict message in log
Status: CLOSED DUPLICATE of bug 310165
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: 3.2   Edit
Assignee: Chris Jaun CLA
QA Contact: Nitin Dahyabhai CLA
URL: CSN 59846 2009
Whiteboard:
Keywords:
: 218330 247954 250464 282473 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-29 15:44 EDT by David Williams CLA
Modified: 2010-08-13 11:48 EDT (History)
3 users (show)

See Also:


Attachments
I added some additional enablement statements to help differentiate this from the jdt action. (1.31 KB, patch)
2009-07-13 11:28 EDT, Chris Jaun CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2008-03-29 15:44:47 EDT
Using WTP I20080329055928


I got following in my log ... not sure what I was doing, just seemed to appear when I was doing nothing ... but, I had been switching between Java and JEE perspective, and opening HTML files. 

!ENTRY org.eclipse.ui.workbench 2 0 2008-03-29 15:27:29.830
!MESSAGE A handler conflict occurred.  This may disable some commands.
!SUBENTRY 1 org.eclipse.ui.workbench 2 0 2008-03-29 15:27:30.268
!MESSAGE Conflict for 'org.eclipse.wst.jsdt.ui.edit.text.java.open.editor':
HandlerActivation(commandId=org.eclipse.wst.jsdt.ui.edit.text.java.open.editor,
	handler=ActionHandler(org.eclipse.wst.jsdt.ui.actions.OpenAction@5c185c18),
	expression=AndExpression(org.eclipse.ui.SubActionBars$1@63986398,ActivePartExpression(org.eclipse.ui.navigator.CommonNavigator@bc00bc),WorkbenchWindowExpression(org.eclipse.ui.internal.WorkbenchWindow@60626062)),sourcePriority=1064961)
HandlerActivation(commandId=org.eclipse.wst.jsdt.ui.edit.text.java.open.editor,
	handler=ActionHandler(org.eclipse.wst.jsdt.ui.actions.OpenAction@5c185c18),
	expression=AndExpression(org.eclipse.ui.SubActionBars$1@63986398,ActivePartExpression(org.eclipse.ui.navigator.CommonNavigator@bc00bc),WorkbenchWindowExpression(org.eclipse.ui.internal.WorkbenchWindow@60626062)),sourcePriority=1064961)
Comment 1 Kaloyan Raev CLA 2008-04-24 15:08:42 EDT
I'd like to mention that this warning quite common. It appears during the J2EE Tools smoke testing. I cannot give exact steps to reproduce. I have notice that it appears while I am working with the Project Explorer view. 
Comment 2 Kaloyan Raev CLA 2008-07-17 14:24:25 EDT
Do you plan looking into this soon? I still see this in the error log with the M-3.0.1-20080717094056 build. 
Comment 3 Phil Berkland CLA 2008-07-18 16:06:10 EDT
I too have seen this in the log (long after the problem occured), but I have had no success in finding the steps to recreate the problem.  There is nothing obviously wrong with the plugin.xml so I need to be able to recreate the problem in order to fix.
Comment 4 Phil Berkland CLA 2008-07-18 16:09:59 EDT
*** Bug 218330 has been marked as a duplicate of this bug. ***
Comment 5 Phil Berkland CLA 2008-09-29 17:23:01 EDT
*** Bug 247954 has been marked as a duplicate of this bug. ***
Comment 6 Chris Jaun CLA 2009-03-24 11:31:00 EDT
Steps to reproduce:

1. Create a Dynamic Web Project.
2. In Project Explorer expand the WebContent folder.
3. Right-click on the WebContent folder and create a new JSP.
4. After the JSP is created and opened right-click on the page in Project Explorer, but don't click on anything in the menu. Close the menu.
5. Right-click on the WebContent folder again. Hover over the New sub-menu.

9 out of 10 times the conflict message appears in the log after the final step.
Comment 7 Chris Jaun CLA 2009-03-24 16:35:08 EDT
JSDT and JDT are adding handlers for action "org.eclipse.ui.navigator.Open".

There seems to be some conflict in the SubActionBars.setGlobalActionHandler(String actionID, IAction handler) method.

It looks like it is supposed to remove the existing JSDT action before it adds a new one, but that is not happening. I think it tries to remove the JDT action instead.

This needs some more investigation. I'm not really sure how these handlers are supposed to work.

Revised steps:

1. Have a dynamic web project with a JSP in its WebContent folder. The JSP does not need to be open.
2. Expland the WebContent folder and right-click on the JSP. Close the menu without selecting anything.
3. Right-click on the WebContent folder.

The error is logged at this time. It only happens the first time you click on the folder after launching the workbench. 

Comment 8 Nitin Dahyabhai CLA 2009-04-14 16:55:11 EDT
*** Bug 250464 has been marked as a duplicate of this bug. ***
Comment 9 Chris Jaun CLA 2009-07-06 10:49:10 EDT
*** Bug 282473 has been marked as a duplicate of this bug. ***
Comment 10 Renato Silva CLA 2009-07-06 18:27:17 EDT
One year and no work on this? :)

As I mentioned in bug 282473, I suspect this is affecting Bazaar plugin, as this error does not raise when I'm using ascii-only paths. When I change the project to a non-ascii path, this error shows up in log view, and I can't use the 'compare to > latest from branch' Bazaar option.

This bug is being watched by Launchpad at https://bugs.launchpad.net/bzr-xmloutput/+bug/388300.
Comment 11 Chris Jaun CLA 2009-07-07 09:26:14 EDT
The handler exception that you identified is a known problem.

We would certainly appreciate any contributions from you if you'd like to see defects such as this one be fixed at a faster rate. I'd be happy to point you to the relevant plugins.

Thanks,
Chris
Comment 12 Renato Silva CLA 2009-07-07 15:58:58 EDT
Ok, I appreciate any help you can give me to find a solution, specially because I'm not very familiar with plugin development.
Comment 13 Renato Silva CLA 2009-07-07 17:04:58 EDT
That's weird, I couldn't reproduce the bug in Ganymede with the provided steps in comment 7, and in Galileo the error raises when I'm using a non-ascii path for the project.
Comment 14 Renato Silva CLA 2009-07-09 15:01:32 EDT
Any idea on which CVS modules to checkout and where to put breakpoints?
Comment 15 Chris Jaun CLA 2009-07-09 16:14:40 EDT
Hi Renato,

In response to comment #13:

I'm able to reproduce this problem pretty regularly in both versions. I know it only happens the first time I open a new workspace. I haven't had a chance to try with the non-ascii paths yet.

Thanks for offering to help.

We fixed a similar bug a little while back. Let me look that one up and see how that was fixed. It could be something similar.

Thanks,
Chris

Comment 16 Chris Jaun CLA 2009-07-10 17:41:50 EDT
It looks like the root of the problem is that JDT and JSDT both add open editor actions with the same activation parameters. This leads to the conflict.

I think I need to update the enablement statement for the JSDT command. Perhaps it should be limited to use in the Script Explorer. 
Comment 17 Renato Silva CLA 2009-07-12 03:51:59 EDT
I solved my issue with Bazaar plugin. The problem was not related to JSDT at all, I'm sorry.
Comment 18 Chris Jaun CLA 2009-07-13 11:28:01 EDT
Created attachment 141429 [details]
I added some additional enablement statements to help differentiate this from the jdt action.
Comment 19 Chris Jaun CLA 2009-07-13 11:29:16 EDT
Code checked into 3.2 stream.
Comment 20 Chris Jaun CLA 2009-10-13 11:56:02 EDT
1. Create a Dynamic Web Project.
2. Create a html page.
3. Click the collapse all button in Project Explorer.

The handler conflict shows up.
Comment 21 Chris Jaun CLA 2009-10-13 11:57:46 EDT
More edits to the enablement statement.
Comment 22 Kaloyan Raev CLA 2010-08-12 12:57:49 EDT
This warning log still shows up in WTP 3.2.2 builds.
Comment 23 Chris Jaun CLA 2010-08-13 11:48:04 EDT

*** This bug has been marked as a duplicate of bug 310165 ***