Community
Participate
Working Groups
Build ID: I20080305-1100 Steps To Reproduce: 1. Create a new feature which contains update site and discovery site URL in its feature.xml 2. Add the new feature to directory where eclipse installed 3. Restat eclipse and the update site and discovery site should be listed in the Manage Site as known sites and the features on the sites should be listed as available features More information:
I don't think this is an UM bug. His expectation is that a discovery site in an installed feature.xml should show up as an available repository in the p2 UI.
Is that a reasonable expectation?
Repositories will have the ability to add additional repositories, which ends up providing a similar mechanism (bug 220554) except that it has a coarser granularity. Another way to achieve this is of course to write a touchpoint action causing the addition of the site when the feature is installed. Tentatively marking as 3.4.
I'll look at this as part of work on associate sites.
I have implemented this for features that are "dropped in" to Eclipse in either eclipse/feature or eclipse/dropins. However, this does not work for features that are installed via p2 API or UI. When a feature is installed by p2, we currently never parse the feature.xml file so we have no opportunity to extract this data. We will minimally need to support this for the case of installing from a legacy update sites. I think the get the same semantics in p2 we'll need to allow associating repositories with an IU, and then when that IU is installed its associated repositories become available. If we just add the repository at the moment we parse feature.xml, then the repository will be added even in cases where we decided not to install that feature.
The eclipse touchpoint "looks" at the features in order to add them to the platform.xml (see PlatformConfigurationWrapper class). Therefore it could be possible to implement the addition of repositories when features are being added. That said, I'm not sure if it is that important to re-implement exactly the same behavior than UM provided. For example, I think it may be enough for all the additional repositories appearing in all the features of a site to be automatically added when the site is added. In the case of legacy update sites, this list could be computed when we are actually generating the metadata repo for the update site.
Support for the use case described in comment #0 was added last week. I have opened bug 228046 for supporting addition of discovery sites for features installed via the p2 UI.
1. Download eclipse-SDK-I20080421-1322-win32.zip 2. unzip the file and start eclipse 3. Go to the Software Updates page Since the following URL exists in many features as update URL, should I expect it on the available sites? http://download.eclipse.org/eclipse/updates/3.4 It's not there. I'm reopening the bug
Bug 228687 was preventing this from working. I will test again with the next nightly build and then close when I confirm it is working.
Verified in I20080415-1646 1) Started new workspace 2) Observe http://download.eclipse.org/eclipse/updates/3.4 is listed in Available Software tab 3) Click manage sites, observe Ganymede site is available but unchecked by default 4) Shutdown 5) Unzip an extra feature in eclipse/features that defines its own update site 6) Restart, and observe feature update URL is listed in available software tab.
The build id from yesterday's build was wrong. This was tested in the I20080427-2000 build.
Thank you for fixing this bug. But I have to tell you that it seems to be broken again in eclipse-SDK-I20080429-0100-win32.zip. I’m now wondering how we can organize these update/repository sites. As a product, we want to be the only update provider to all the components. We need to test all the component updates before shipping them to the customers. Currently the main feature of our product includes all the component features and handles the update for them. I was trying to set it up the same way, but didn’t get it yet. 1.Created a feature my.feature to include both feature org.eclipse.rse.sdk and org.eclipse.sdk. 2.Created an update site project to include my.feature. 3.Copied my update site to another place and added it to the Software sites. 4.Expanded the plus sign before my update site in the avaliable software tab 5.There was no feature listed Is the above the right approach?
Checked in the following build and failed to find the eclipse update site. Build id: I20080502-0100
The steps described in comment #0 work for me in 3.4 M7 build. If you drop a new feature into the platform, the feature update site and discovery sites will be found and added to the list of repositories in the "manage sites" dialog. There is a separate problem with the update site for the pre-installed features not being added to the list of repositories (the Ganymede site). This is an unrelated build-time issue captured in bug 224278.
