Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 224482 - [reconciler] Need to watch the platform.xml
Summary: [reconciler] Need to watch the platform.xml
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 225202 (view as bug list)
Depends on: 223422
Blocks: 223016
  Show dependency tree
 
Reported: 2008-03-27 18:06 EDT by DJ Houghton CLA
Modified: 2008-04-17 09:31 EDT (History)
6 users (show)

See Also:


Attachments
patch (21.55 KB, patch)
2008-03-27 18:06 EDT, DJ Houghton CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2008-03-27 18:06:55 EDT
Created attachment 93893 [details]
patch

As part of the backwards compatibility story, we need to watch the platform.xml file in case the user uses the old update manager UI (or a headless app) to install a feature. In this case we would want to detect a change to the platform.xml file and install the right bundles into the bundles.info.

I've attached a patch for my current work. Ok, so its not current and won't apply to HEAD. But I don't want to lose this code.

At last check it was working, but we were getting 2 "hey your config has changed, did you want to restart?" dialogs. One from the update manager noticing that the platform.xml had changed and one from p2 because the bundles.info had changed.
Comment 1 Simon Kaegi CLA 2008-03-27 18:10:03 EDT
we need to think about how we want to reference the various watched dropin repositories. In bug 223422 we're currently nulling them out after doing the reconcile associated with bundle activation so we need to be a bit cautious here with re-enabling the platform.xml listener.
Comment 2 DJ Houghton CLA 2008-04-11 16:42:48 EDT
Just to add an update of where we are:
- we released most of our code to HEAD
- the Activator for the reconciler.dropins bundle still has the call to watch the configuration disabled
- we can install features (e.g. CDT) with the old Update Manager UI to new sites (e.g. d:/temp/ext.location/) and then on restart they are known to p2

We have problems with uninstall but they are known problems since the links folder is treated the same as the dropins folder and we can't uninstall anything from there. (via the UI) This is due to the way that we construct the metadata for the dropins and have an all-containing super-IU.

Comment 3 DJ Houghton CLA 2008-04-15 11:06:38 EDT
*** Bug 225202 has been marked as a duplicate of this bug. ***
Comment 4 DJ Houghton CLA 2008-04-15 13:25:53 EDT
Dave and I feel good about our progress here and hope to release our changes to HEAD this week. Setting target to M7.
Comment 5 DJ Houghton CLA 2008-04-16 19:02:01 EDT
I have enabled the platform.xml watching support in HEAD.
Comment 6 DJ Houghton CLA 2008-04-17 09:31:59 EDT
I am going to close this bug report as the main functionality has been released. New bug reports can be opened for any bugs that come up.

Some already existing bugs of interest:

bug 222567 - Enable site filtering policy in platform.xml watcher
bug 227547 - Changes only noticed on startup
bug 221573 - Strange file:. URL in platform.xml (missing platform:/base/ URLs)